Skip to content

During install, handle failure to install toolchain better #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brson opened this issue Apr 6, 2016 · 3 comments
Open

During install, handle failure to install toolchain better #275

brson opened this issue Apr 6, 2016 · 3 comments

Comments

@brson
Copy link
Contributor

brson commented Apr 6, 2016

Right now, we do the (very simple) rustup install, then install stable. If stable fails, then the installation is reported as failed, but rustup is still installed.

I'm not sure off hand if it's better to report a successful install with caveats or to try to revert the install completely.

Mentioned in #260

@peschkaj
Copy link
Contributor

peschkaj commented Apr 6, 2016

This came up in #rust-beginners yesterday. A user had installed rustup through rustup-setup.exe, but they had no working rust.

@mbrubeck suggested that the user run rustup default stable followed by rustup update stable - this resulted in a working installation.

Maybe we could keep rustup installed, but if stable fails, display a message to the user that something went wrong and prompt them to run those commands and report any errors as an issue.

@brson
Copy link
Contributor Author

brson commented Apr 6, 2016

SGTM

@brson
Copy link
Contributor Author

brson commented Apr 25, 2016

A special error message for the case where the stable toolchain doesn't exist could be helpful too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants