Skip to content
This repository was archived by the owner on Nov 18, 2022. It is now read-only.

rls-vscode doesn't work with multi-root vscode workspaces #194

Closed
TyOverby opened this issue Nov 21, 2017 · 7 comments
Closed

rls-vscode doesn't work with multi-root vscode workspaces #194

TyOverby opened this issue Nov 21, 2017 · 7 comments
Assignees
Labels

Comments

@TyOverby
Copy link

https://code.visualstudio.com/docs/editor/multi-root-workspaces

No autocomplete / no red-squigglies, etc

RLS shows that it has loaded and is Done, but it everything functions as though rls-vscode isn't even installed.

@yamafaktory
Copy link

On my laptop, checking the RLS logs in VSCode gives me:

note: rustc 1.23.0-nightly (5f44c653c 2017-11-24) running on x86_64-apple-darwin

thread 'rustc' panicked at 'Could not deserialize save-analysis config: MissingFieldError("reachable_only")', src/libcore/result.rs:906:4
note: Run with `RUST_BACKTRACE=1` for a backtrace.

I don't know if this is related to workspaces, but this is very likely related to rust-lang/rust#46244.

@nrc
Copy link
Member

nrc commented Nov 26, 2017

@yamafaktory this is not related to workspaces, it should be fixed soon...

@yamafaktory
Copy link

@nrc Thanks a lot for the feedback, I'll wait for it! It's an awesome work you're doing & an awesome tool too!

@Xanewok
Copy link
Member

Xanewok commented Dec 1, 2017

The official lsp client we're using already supports workspace extension (https://github.com/Microsoft/vscode-languageserver-node/blob/master/protocol/src/protocol.workspaceFolders.proposed.md), so this needs only toggling on from the client side.
This would also need support from the RLS itself, tracked over at rust-lang/rls#608.

@nrc nrc added the P-High label Feb 18, 2018
@kohensu
Copy link

kohensu commented May 10, 2018

With a workspace like this:

Workspace
  |- scripts (or whatever)
  |- docs (or whatever)
  `- rust_project
        |- src
        `- Cargo.tml

(i.e. containing several folders that are not rust related and one that is a rust project)

the extensions will not work because the root of the rust project is not correct.

Is it possible, in this case, to start RLS on the rust folder of the workspace ?
(I suppose this does't need any modifications in RLS)

@kohensu
Copy link

kohensu commented May 10, 2018

In addition, if a workspace contains several unrelated rust projects, is it possible to start one RLS by rust folder ?
(I suppose this does't need any modification in RLS either, but must be a more involved change in rls-vscode)

@nrc nrc self-assigned this Jun 4, 2018
@nrc
Copy link
Member

nrc commented Jun 21, 2018

Fixed.

@nrc nrc closed this as completed Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants