feat: add tls-no-provider feature #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @MA-DDN , thanks for the contribution! Adding tls-no-provider feature is a great idea. Would you mind also updating the available-features section of the README with a short description of this flag? Thanks |
Ok, I have added a short description of the feature to the readme. |
MA-DDN
changed the title
hashemix
changed the title
hashemix
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Adds a tls-no-provider feature as currently enabling tls support pulls in the aws-lc crate which causes conflicts if you are using another crypto provider.
✨ Changes Made
🛠️ Testing Steps
Add the rust-mcp-stack to a project with no existing dependancy on aws-lc with the ssl feature disabeld and the tls-no-provider feature enabled. Check that when you build the project that the aws-lc crates aren't pulled in to the Cargo.lock file.