Skip to content

Generalized rows/columns producers #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bluss opened this issue Apr 3, 2017 · 1 comment
Closed

Generalized rows/columns producers #302

bluss opened this issue Apr 3, 2017 · 1 comment

Comments

@bluss
Copy link
Member

bluss commented Apr 3, 2017

.inner_iter() as it is today, is a generalized rows iterator. It produces all rows, even for more-dimensional arrays. What “rows” means is then the last axis, Axis(1) in a 2D array and Axis(n - 1) in an nd array.

The method names rows(), columns() are taken (for row counts and column counts). We can't use row_iter as the name, because it will return a rows producer and iterable, not iterator.

There is also the choice of what generalized columns should mean (Always the outermost axis, or always the next to last axis?)

(Break because inner_iter will be renamed and generalized).

@bluss
Copy link
Member Author

bluss commented Apr 5, 2017

I decided it's natural that generalized columns = whatever's contiguous in generalized f-contiguous arrays. Which means Axis(0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant