-
Notifications
You must be signed in to change notification settings - Fork 207
Don't fall back to file I/O on Linux when Rust only supports kernels guaranteed to have it #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I like this idea, it also serves as a bit of a test run for removing such file-based support once rust increases its supported kernel version. |
Sounds good to me! |
What about Android targets?
So we probably can disable file fallback for Android targets as per our platform support policy? |
I have been assuming |
That documentation was introduced in 1.47.0: https://doc.rust-lang.org/1.47.0/rustc/platform-support.html |
According to https://doc.rust-lang.org/beta/rustc/platform-support.html, there are only a handful of target architectures where Rust supports kernels that are so old that they would not have the
getrandom
syscall. Notablyriscv64gc
andaarch64
are guaranteed to havegetrandom
according to the Rust kernel support policy. For those architectures we should not have enable the fallback logic at all. I suggest in particular that we have an allowlist of target architectures where we allow the fallback, which would bei686
,x86_64
,arm
,armv7
,powerpc
,powerpc64
,powerpc64le
.s390x
,i586
, according to the Rust documents.The text was updated successfully, but these errors were encountered: