Skip to content

Update to OpenBLAS 0.3.3 #26052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tobihan opened this issue Aug 12, 2018 · 23 comments
Closed

Update to OpenBLAS 0.3.3 #26052

tobihan opened this issue Aug 12, 2018 · 23 comments

Comments

@tobihan
Copy link

tobihan commented Aug 12, 2018

OpenBLAS 0.3.2 came out and was uploaded to Debian. When attempting to build the sage 8.3 Debian package (with one thread) with this version, OpenBLAS causes a crash during the docbuild, see attached log.

A bug in OpenBLAS that involves the same error message ("OpenBLAS : Program will terminate because you tried to start too many threads.") is OpenMathLib/OpenBLAS#1641

Our temporary workaround for now is to use Atlas (which we already used before for architectures which are not supported by OpenBLAS).

Please consider updating OpenBLAS in sage.

Openblas 0.3.3 is now out and the threading behavior which caused many bug reports is reverted for now.
Prepared upstream tarball renamed to OpenBLAS-0.3.3.tar.gz

CC: @jpflori @vbraun @jdemeyer @mo271 @thecaligarmo @kiwifb @embray @tscrim

Component: packages: standard

Author: François Bissey

Branch/Commit: bdf02cf

Reviewer: Erik Bray

Issue created by migration from https://trac.sagemath.org/ticket/26052

@tobihan tobihan added this to the sage-8.4 milestone Aug 12, 2018
@tobihan
Copy link
Author

tobihan commented Aug 12, 2018

comment:1

Attachment: sage_8.3-openblas_error.log

@kiwifb
Copy link
Member

kiwifb commented Aug 16, 2018

comment:3

I am not experiencing this problem in sage-on-gentoo. However I decided to only use "regular threads" and no "openmp threads" in openblas some time ago. I suspect that is why I am not affected at this stage. It may be that I have the wrong picture of threading in openblas as well.

@kiwifb
Copy link
Member

kiwifb commented Oct 25, 2018

comment:4

I believe the problem has been addressed in 0.3.3 where they decided to switch back to the previous behavior with threads until they have fixed all the issues that have cropped in 0.3.2.

For the record I am using 0.3.3 (without openmp threads) in my own sage-on-gentoo builds.

@kiwifb
Copy link
Member

kiwifb commented Nov 14, 2018

Branch: u/fbissey/openblas-0.3.3

@kiwifb
Copy link
Member

kiwifb commented Nov 14, 2018

comment:5

All the cygwin patches failed but most of the bits appears to have been merged upstream. Still someone should check cygwin with this release.


New commits:

bdf02cfupgrade to openblas 0.3.3

@kiwifb

This comment has been minimized.

@kiwifb
Copy link
Member

kiwifb commented Nov 14, 2018

Author: François Bissey

@kiwifb
Copy link
Member

kiwifb commented Nov 14, 2018

Commit: bdf02cf

@kiwifb kiwifb changed the title Update to OpenBLAS 0.3.2 Update to OpenBLAS 0.3.3 Nov 14, 2018
@kiwifb kiwifb modified the milestones: sage-8.4, sage-8.5 Nov 14, 2018
@embray
Copy link
Contributor

embray commented Nov 29, 2018

comment:7

I can confirm that the aforementioned cygwin-related patches should be safe to remove as I've had them accepted upstream for some time. I'll still want to run tests on this though. I think I can go ahead and get that started now.

@embray
Copy link
Contributor

embray commented Nov 29, 2018

comment:8

I am rebasing this on 8.5.beta5 first though, though that shouldn't make too much difference.

@embray
Copy link
Contributor

embray commented Nov 29, 2018

comment:9

Also I'm getting invalid checksum when I use the tarball downloaded from github...?

@dimpase
Copy link
Member

dimpase commented Nov 29, 2018

comment:10

Replying to @embray:

Also I'm getting invalid checksum when I use the tarball downloaded from github...?

could you wget the tar file and rename it? That oh so clever github API might do something more than that...

@dimpase
Copy link
Member

dimpase commented Nov 29, 2018

comment:11

hmm, no, indeed, it seems to be wrong (and as I came here from a duplicate ticket I had for the same task, I already had my tarfile all set...)
What I get is md5 30e2f8d7317e84dde5a37152173848f1

@embray
Copy link
Contributor

embray commented Nov 29, 2018

comment:12

I'm not sure what you mean. That's exactly what I did. That's...disconcerting. I would hope that tarballs downloaded from GitHub wouldn't differ depending on when they were downloaded >_>

@dimpase
Copy link
Member

dimpase commented Nov 29, 2018

comment:13

well, let us wait for NZ to comment on this

@embray
Copy link
Contributor

embray commented Nov 29, 2018

comment:14

Either way I'm going ahead with building it.

@kiwifb
Copy link
Member

kiwifb commented Nov 29, 2018

comment:15

Replying to @embray:

I'm not sure what you mean. That's exactly what I did. That's...disconcerting. I would hope that tarballs downloaded from GitHub wouldn't differ depending on when they were downloaded >_>

Unfortunately, it is known to happen cschwan/sage-on-gentoo#529 . It may be that the release are not cut properly since there are repos for which I have no issues. In any case github lets you upload your own tarball prepared with sdist and the like. And people should really do it.

So someone will have to host a reference tarball until it makes it to the sage mirror.

@dimpase
Copy link
Member

dimpase commented Nov 29, 2018

comment:16

I've raised OpenMathLib/OpenBLAS#1891

@embray
Copy link
Contributor

embray commented Nov 30, 2018

Reviewer: Erik Bray

@embray
Copy link
Contributor

embray commented Nov 30, 2018

comment:17

Ok, looks good to me otherwise.

@kiwifb
Copy link
Member

kiwifb commented Nov 30, 2018

comment:18

Ok added the tarball matching the checksum in the description. Since Erik says he is happy with it I am switching it to positive review.

@kiwifb

This comment has been minimized.

@vbraun
Copy link
Member

vbraun commented Dec 1, 2018

Changed branch from u/fbissey/openblas-0.3.3 to bdf02cf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants