Skip to content

Commit cbd07e9

Browse files
authored
fix(visual-picker): add focus styling (#3093)
1 parent 42cb1d0 commit cbd07e9

File tree

3 files changed

+22
-8
lines changed

3 files changed

+22
-8
lines changed

ui/components/visual-picker/coverable-content/_index.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,10 @@
5757
box-shadow: $elevation-shadow-4;
5858
}
5959

60+
&:focus ~ label .slds-visual-picker__body > *:first-child {
61+
text-decoration: underline;
62+
}
63+
6064
/**
6165
* @summary Non-selected state
6266
* @selector .slds-is-not-selected

ui/components/visual-picker/coverable-content/example.jsx

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@ import { UtilityIcon } from '../../icons/base/example';
1717
// Partial(s)
1818
/// ////////////////////////////////////////
1919

20+
export const Option = props => (
21+
<span className="slds-text-title" key={_.uniqueId()}>
22+
{props.label}
23+
</span>
24+
);
25+
2026
export let VisualPicker = props => {
2127
const uniqueId = _.uniqueId('visual-picker-');
2228

@@ -139,15 +145,15 @@ export default (
139145
icon
140146
sprite="utility"
141147
symbol="connected_apps"
142-
label="Connected App"
148+
label={<Option label="Connected App" />}
143149
size="medium"
144150
/>
145151
<VisualPicker
146152
type="radio"
147153
icon
148154
sprite="utility"
149155
symbol="custom_apps"
150-
label="Custom App"
156+
label={<Option label="Custom App" />}
151157
size="medium"
152158
/>
153159
</FormElementControl>
@@ -167,7 +173,7 @@ export let states = [
167173
icon
168174
sprite="utility"
169175
symbol="connected_apps"
170-
label="Connected App"
176+
label={<Option label="Connected App" />}
171177
size="medium"
172178
/>
173179
<VisualPicker
@@ -176,7 +182,7 @@ export let states = [
176182
icon
177183
sprite="utility"
178184
symbol="custom_apps"
179-
label="Custom App"
185+
label={<Option label="Custom App" />}
180186
size="medium"
181187
/>
182188
</FormElementControl>
@@ -198,23 +204,23 @@ export let examples = [
198204
icon
199205
sprite="standard"
200206
symbol="account"
201-
label="Account"
207+
label={<Option label="Account" />}
202208
size="medium"
203209
/>
204210
<VisualPicker
205211
type="checkbox"
206212
icon
207213
sprite="standard"
208214
symbol="lead"
209-
label="Lead"
215+
label={<Option label="Lead" />}
210216
size="medium"
211217
/>
212218
<VisualPicker
213219
type="checkbox"
214220
icon
215221
sprite="standard"
216222
symbol="orders"
217-
label="Orders"
223+
label={<Option label="Orders" />}
218224
size="medium"
219225
/>
220226
</FormElementControl>

ui/components/visual-picker/vertical/_index.scss

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,15 @@
2222

2323
+ .slds-visual-picker_vertical {
2424
margin-left: 0;
25-
margin-top: $spacing-large;
25+
margin-top: $spacing-medium;
2626
}
2727

2828
.slds-visual-picker__figure,
2929
.slds-visual-picker__body {
3030
width: $size-large;
3131
}
32+
33+
input:focus ~ label .slds-visual-picker__text .slds-text-heading_medium {
34+
text-decoration: underline;
35+
}
3236
}

0 commit comments

Comments
 (0)