Skip to content

Commit cdf72cd

Browse files
author
Ayesha Mazumdar
authored
fix(inputs): Update checkboxes and radios to have proper value attribute (#3196)
1 parent 306c5af commit cdf72cd

File tree

34 files changed

+54
-37
lines changed

34 files changed

+54
-37
lines changed

ui/components/activity-timeline/__tests__/__snapshots__/Activity_Timeline_Expandable_renders_a_task_timeline_item.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

ui/components/activity-timeline/__tests__/__snapshots__/Activity_Timeline_Expandable_renders_a_timeline_item_trigger_with_a_task_checkbox.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

ui/components/activity-timeline/__tests__/__snapshots__/Activity_Timeline_Expandable_renders_a_timeline_item_with_icons.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

ui/components/activity-timeline/__tests__/__snapshots__/Activity_Timeline_Expandable_renders_the_deprecated_combined_timeline.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

ui/components/checkbox-button-group/base/example.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ export let Checkbox = props => (
3030
disabled={props.disabled}
3131
defaultChecked={props.checked}
3232
id={props.id}
33+
value={props.id}
3334
name="checkbox"
3435
type="checkbox"
3536
/>

ui/components/checkbox-button/__tests__/__snapshots__/renders_a_checked_checkbox_button.json

Lines changed: 3 additions & 2 deletions
Large diffs are not rendered by default.

ui/components/checkbox-button/__tests__/__snapshots__/renders_a_default_checkbox_button.json

Lines changed: 3 additions & 2 deletions
Large diffs are not rendered by default.

ui/components/checkbox-button/__tests__/__snapshots__/renders_a_disabled_checkbox_button.json

Lines changed: 3 additions & 2 deletions
Large diffs are not rendered by default.

ui/components/checkbox-button/base/example.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ export let CheckboxAddButton = props => {
1919
className="slds-assistive-text"
2020
type="checkbox"
2121
id={uniqueId}
22+
value={uniqueId}
2223
disabled={props.disabled}
2324
defaultChecked={props.checked}
2425
tabIndex={props.tabIndex}

ui/components/checkbox-toggle/base/example.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ export let FauxLabel = props => (
4848
export let Checkbox = props => (
4949
<input
5050
name={props.uniqueId}
51+
value={props.uniqueId}
5152
type="checkbox"
5253
disabled={props.disabled}
5354
defaultChecked={props.checked}

0 commit comments

Comments
 (0)