Skip to content

Please label it properly #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Garfius opened this issue Jul 11, 2019 · 5 comments
Closed

Please label it properly #268

Garfius opened this issue Jul 11, 2019 · 5 comments

Comments

@Garfius
Copy link

Garfius commented Jul 11, 2019

Once long tested the code, and seen so many issues, and understanding the hardships of the general prupose. I understand this code has no possible professional application.

Therefore, i sincerely ask to modify readme.md to show a warning message regarding a demonstration prupose.

Thanks.

@torntrousers
Copy link
Contributor

It works well for me. Would you list out the issues you've seen?

@Garfius
Copy link
Author

Garfius commented Jul 12, 2019

The most important:

Can't work nore than a few hours.

Interrupt driven receive method is not reliable.

@mchacher
Copy link

Please read following issues. I did the patch on my side.
// #218
// #222
Since the callback is done under interupt, limit as much as possible the code in the ISR.

@torntrousers
Copy link
Contributor

torntrousers commented Jul 12, 2019

@mchacher - if you've got a patch for that issue would you open a PR or show the diff?

@mchacher
Copy link

mchacher commented Jul 12, 2019

@torntrousers , just comment line :
writeRegister(REG_FIFO_ADDR_PTR, 0);
at end of the method void LoRaClass::handleDio0Rise()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants