Skip to content

Make this lib Strict Mode compliant #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gustavopch opened this issue Nov 19, 2019 · 8 comments
Open

Make this lib Strict Mode compliant #198

gustavopch opened this issue Nov 19, 2019 · 8 comments

Comments

@gustavopch
Copy link

Getting the following error when using this lib in Strict Mode:

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of InputElement which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://fb.me/react-strict-mode-find-node

This line seems to be the cause: https://github.com/sanniassin/react-input-mask/blob/master/src/index.js#L270

This should be fixed to avoid issues with Concurrent Mode (which will soon be released):

In Concurrent Mode, the lifecycle methods previously marked as “unsafe” actually are unsafe, and lead to bugs even more than in today’s React. We don’t recommend trying Concurrent Mode until your app is Strict Mode-compatible.

@igorprandini
Copy link

I have the same problem!
Any solution for this topic?

@arashkay
Copy link

Any ETA to fix this?

@luisfagottani
Copy link

any?

@marcosem
Copy link

Any news on this?
Thank you!

@fuale
Copy link

fuale commented Aug 25, 2020

Any news, meus camaradas?

@lucascco
Copy link

I think that this lib was abandoned... =(

@ChrisCrossCrash
Copy link

Are there any popular forks of this repository that is being actively maintained? It would be nice to get this fixed.

@ianchanning
Copy link

I have a fix for this here: #308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants