Skip to content

Reject svn commits with no log messages #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scabug opened this issue Sep 4, 2007 · 4 comments
Closed

Reject svn commits with no log messages #53

scabug opened this issue Sep 4, 2007 · 4 comments
Assignees

Comments

@scabug
Copy link

scabug commented Sep 4, 2007

Hello,

This is from a committer who has commit rights to the Subversion project
itself and a user of Scala, which is a great language, thank you!

Please add a pre-commit script to reject commits without a log
message, as not having a log message is bad practice and makes
it harder for people to see and determine what work is done.

Example recent revisions with no log message include r12785, r12780,
r12772.

Please add this to your pre-commit, changing SVNLOOK to point at
the svnlook binary on your system.

# Make sure that the log message contains some text.
SVNLOOK=/usr/local/bin/svnlook
$$SVNLOOK log -t "$$TXN" "$$REPOS" | grep "[a-zA-Z0-9]" > /dev/null || {
  echo "$$0: no log message for txn $$TXN" 1>&2
  exit 1
}

It would be good to ask those authors with no commit message to
go back and add one using this command:

$$ svn propedit --revprop -r N svn:log

Regards,
Blair

@scabug
Copy link
Author

scabug commented Sep 4, 2007

Imported From: https://issues.scala-lang.org/browse/SI-53?orig=1
Reporter: Commit Message Bot (anonymous)

@scabug
Copy link
Author

scabug commented Sep 10, 2007

@fsalvi said:
Why not, but is it really better to have "fix" or "update" instead of nothing ?
I'm afraid we can't force people to add log messages if they don't want to do it...

@scabug
Copy link
Author

scabug commented Sep 11, 2007

@michelou said:
Decided in 2007/09/11 meeting: adding comments is a social issue, not a technical one, so issue is marked as "wontfix".

@scabug
Copy link
Author

scabug commented Jan 14, 2009

@odersky said:
Milestone 2.6.1 deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants