Review scala.collection public members

[lrytz]

At some point before shipping we should review public types / methods in the collection package. The following can be pasted in the repl:

:power

import symtab.Flags

def packagesIn(p: Symbol): List[Symbol] = {
  val ps = p.info.membersBasedOnFlags(0, Flags.PACKAGE).toList
  ps ::: ps.flatMap(packagesIn)
}

val collP = rootMirror.getPackage(TermName("scala.collection"))
val allPackages = collP :: packagesIn(collP)

def packageMembers(p: Symbol) = {
  // removes non-existing members from the scope (List$)
  p.info.members.foreach(_.initialize)
  p.info.members.toList.filter(m => !m.isPackage)
}


val msInPackages = allPackages.map(p => (p, {
  val ms = packageMembers(p)
  ms.groupMap(m => m.accessString)(m => {
    val typeMs = m.info.decls.toList.filter(m => !m.isSynthetic)
    (m, typeMs.groupBy(m => m.accessString))
  })
}))

for ((p, packageMsByAccess) <- msInPackages) {
  println(s"${p.fullNameString}:")
  for ((pa, pms) <- packageMsByAccess) {
    val paa = if (pa.isEmpty) "<public>" else pa
    println(s"  $paa:")
    for ((m, typeMsByAccess) <- pms) {
      println(s"    $m:")
      for ((ta, tms) <- typeMsByAccess) {
        val taa = if (ta.isEmpty) "<public>" else ta
        println(s"      $taa:")
        println(tms.mkString("        ", "\n        ", ""))
      }
    }
  }
}

Example output: https://gist.github.com/lrytz/54a920d0025913aec4c544862dd74ea0 - can be improved :)

[lrytz]

We should also convert the above code to a partest test to make sure no public members are added accidentially.

[joshlemer]

It would also be handy to include the exposed type of each member, so that nobody accidentally exposes/commits to a return type that's more specific than it should be.