-
Notifications
You must be signed in to change notification settings - Fork 59
add JDK 11 community build #742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
we should stop piling on behemoth 2 any further (it has all three 2.12 builds currently) and spread the jobs around more UPDATE: I did some spreading around already. I should still choose carefully when adding this one |
I tried a run locally and got scala-swing fix here: scala/scala-swing#82 |
I'll do another local run before we ship 2.12.7, and I'll scrutinize the results (that is, each individual failure reason, not just the overall greenness level) more closely than I have so far. |
gah, EDIT: looks like this should work - // the usual thing some projects need on JDK 9
- "--add-modules=java.xml.bind", "-XX:+IgnoreUnrecognizedVMOptions"
+ extra.settings: ${vars.base.extra.settings} [
+ // for JDK9+. one-deeper nesting level makes it apply to build definition
+ ["libraryDependencies += \"javax.xml.bind\" % \"jaxb-api\" % \"2.3.0\""]
+ ] |
job created & assigned to behemoth 2: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-jdk11-integrate-community-build/ |
OpenJDK 11 installed on behemoth 2 (using this as a template):
and in this new run: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-jdk11-integrate-community-build/2/consoleFull I now see |
also made a 2.13 job: https://scala-ci.typesafe.com/job/scala-2.13.x-jdk11-integrate-community-build, assigned to behemoth 1, after following the same JDK installation steps as above |
everything extracts now, at least, as of https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-jdk11-integrate-community-build/4/ . I had to fork coursier and kxbmap-configs to work around the JDK 11 |
having a problems where dbuild shares dealt with it by shutting down all community build jobs on all 3 behemoths, blowing away a cleaner fix would be to have the run script or the config file somehow read the JDK major version being used and include it in some dummy setting so that dbuild would know it matters for reproducible-run purposes. /cc @cunei UPDATE: I guessed wrong, that wasn't the cause. Toni fixed it in dbuild |
declaring victory on basics. new ticket for further improvements: #796 |
now that the JDK 10 build is up and running (#735), let's do 11 next
The text was updated successfully, but these errors were encountered: