From 9742b7ac181ba7bc802b534b8c6a6bf00800ff89 Mon Sep 17 00:00:00 2001 From: Seth Tisue Date: Wed, 11 Jul 2018 17:35:22 -0700 Subject: [PATCH 1/4] disable an Akka test known to fail on JDK 9 only --- configs/community.dbuild | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configs/community.dbuild b/configs/community.dbuild index 039a2700b..f0b57f7e2 100644 --- a/configs/community.dbuild +++ b/configs/community.dbuild @@ -490,8 +490,12 @@ build += { extra.commands: ${vars.default-commands} [ // https://github.com/scala/community-builds/issues/373 "set every apiURL := None" - // UnfoldResourceSourceSpec kept failing. I should report upstream if it persists after next unfreeze + // UnfoldResourceSourceSpec kept failing. I should report upstream if it persists after next unfreeze. + // also note we shouldn't only be disabling the one source file, not the whole project. "set executeTests in streamTests in Test := Tests.Output(TestResult.Passed, Map(), Iterable())" + // known to fail on JDK 9 only (works on 8, 10). ideally we'd conditionally exclude by + // JVM version but it doesn't seem worth fooling with + "set excludeFilter in (Test, unmanagedSources) in `akka-actor-tests` := HiddenFileFilter || \"IndexSpec.scala\"" ] extra.exclude: [ "akka-docs" // this is Sphinx stuff, not really apropos here, no Sphinx on Jenkins anyway From b3549fd6650c2e26dc753d84fc8b49f91cb36c99 Mon Sep 17 00:00:00 2001 From: Seth Tisue Date: Wed, 11 Jul 2018 20:49:30 -0700 Subject: [PATCH 2/4] wip --- configs/community.dbuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/community.dbuild b/configs/community.dbuild index f0b57f7e2..7917ac5e1 100644 --- a/configs/community.dbuild +++ b/configs/community.dbuild @@ -495,7 +495,7 @@ build += { "set executeTests in streamTests in Test := Tests.Output(TestResult.Passed, Map(), Iterable())" // known to fail on JDK 9 only (works on 8, 10). ideally we'd conditionally exclude by // JVM version but it doesn't seem worth fooling with - "set excludeFilter in (Test, unmanagedSources) in `akka-actor-tests` := HiddenFileFilter || \"IndexSpec.scala\"" + "set excludeFilter in (Test, unmanagedSources) in actorTests := HiddenFileFilter || \"IndexSpec.scala\"" ] extra.exclude: [ "akka-docs" // this is Sphinx stuff, not really apropos here, no Sphinx on Jenkins anyway From 6c09d35897fd13ca98572cc329679b5ad58a2286 Mon Sep 17 00:00:00 2001 From: Seth Tisue Date: Thu, 12 Jul 2018 12:24:54 -0700 Subject: [PATCH 3/4] wip --- configs/community.dbuild | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/community.dbuild b/configs/community.dbuild index 7917ac5e1..e5e493030 100644 --- a/configs/community.dbuild +++ b/configs/community.dbuild @@ -485,6 +485,8 @@ build += { extra.options: ["-Dakka.genjavadoc.enabled=false", "-Dakka.scaladoc.diagrams=false", "-Dakka.build.aggregateSamples=false", "-Dakka.test.tags.exclude=performance,timing,long-running", "-Dakka.test.multi-in-test=false" // repo readme recommended "-Xmx2g" + // the usual thing some projects need on JDK 9 + "--add-modules=java.xml.bind", "-XX:+IgnoreUnrecognizedVMOptions" ] extra.projects: ["akka-scala-nightly"] extra.commands: ${vars.default-commands} [ From 9013563064f15d463372d41e7ed795920be60427 Mon Sep 17 00:00:00 2001 From: Seth Tisue Date: Tue, 17 Jul 2018 17:58:41 -0700 Subject: [PATCH 4/4] wip --- configs/community.dbuild | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/configs/community.dbuild b/configs/community.dbuild index b1dde3c96..5b8ab315f 100644 --- a/configs/community.dbuild +++ b/configs/community.dbuild @@ -397,9 +397,11 @@ build += { "set skip in publish in actorTests := false" // makes "configuration not public" errors downstream go away "set every publishMavenStyle := false" - // known to fail on JDK 9 only (works on 8, 10). ideally we'd conditionally exclude by - // JVM version but it doesn't seem worth fooling with - "set excludeFilter in (Test, unmanagedSources) in actorTests := HiddenFileFilter || \"IndexSpec.scala\"" + // IndexSpec is known to fail on JDK 9 only (works on 8, 10). ideally we'd conditionally exclude by + // JVM version but it doesn't seem worth fooling with. + // and then CircuitBreakerSpec fails on JDK 10 only; I reported it in a comment on + // https://github.com/akka/akka/issues/23402 + "set excludeFilter in (Test, unmanagedSources) in actorTests := HiddenFileFilter || \"IndexSpec.scala\" || \"CircuitBreakerSpec.scala\"" ] }