use reference to the phase name in ErrorMessagesTests

Author: ingarabr

compiler/src/dotty/tools/backend/jvm/GenBCode.scala

@@ -4,45 +4,32 @@ import dotty.tools.dotc.CompilationUnit
 import dotty.tools.dotc.ast.Trees.{PackageDef, ValDef}
 import dotty.tools.dotc.ast.tpd
 import dotty.tools.dotc.core.Phases.Phase
-import dotty.tools.dotc.core.Names.TypeName
 
 import scala.collection.mutable
-import scala.collection.JavaConverters._
-import scala.tools.asm.{ClassVisitor, CustomAttr, FieldVisitor, MethodVisitor}
+import scala.tools.asm.CustomAttr
 import scala.tools.nsc.backend.jvm._
-import dotty.tools.dotc
-import dotty.tools.dotc.transform.Erasure
 import dotty.tools.dotc.transform.SymUtils._
 import dotty.tools.dotc.interfaces
 import java.util.Optional
 
-import scala.reflect.ClassTag
 import dotty.tools.dotc.core._
 import dotty.tools.dotc.sbt.ExtractDependencies
-import Periods._
-import SymDenotations._
 import Contexts._
-import Types._
 import Symbols._
-import Denotations._
 import Decorators._
 
-import Phases._
-import java.lang.AssertionError
-import java.io.{DataOutputStream, File => JFile}
-import java.nio.file.{Files, FileSystem, FileSystems, Path => JPath}
+import java.io.DataOutputStream
 
-import dotty.tools.io.{Directory, File, Jar}
+import dotty.tools.io.Directory
 
 import scala.tools.asm
 import scala.tools.asm.tree._
-import dotty.tools.dotc.util.{DotClass, Positions}
 import tpd._
 import StdNames._
 import dotty.tools.io._
 
 class GenBCode extends Phase {
-  def phaseName: String = "genBCode"
+  def phaseName: String = GenBCode.name
   private val entryPoints = new mutable.HashSet[Symbol]()
   def registerEntryPoint(sym: Symbol) = entryPoints += sym
 
@@ -80,6 +67,10 @@ class GenBCode extends Phase {
   }
 }
 
+object GenBCode {
+  val name: String = "genBCode"
+}
+
 class GenBCodePipeline(val entryPoints: List[Symbol], val int: DottyBackendInterface)(implicit val ctx: Context) extends BCodeSyncAndTry {
 
   var tree: Tree = _

compiler/src/dotty/tools/dotc/transform/CheckStatic.scala

@@ -2,26 +2,12 @@ package dotty.tools.dotc
 package transform
 
 import core._
-import Names._
-import StdNames.nme
-import Types._
 import dotty.tools.dotc.transform.MegaPhase._
-import ast.Trees._
 import Flags._
 import Contexts.Context
 import Symbols._
-import Constants._
-import Denotations._
-import SymDenotations._
-import Decorators.StringInterpolators
 import dotty.tools.dotc.ast.tpd
-import dotty.tools.dotc.core.Annotations.ConcreteAnnotation
-import scala.collection.mutable
-import DenotTransformers._
-import Names.Name
-import NameOps._
 import Decorators._
-import TypeUtils._
 import reporting.diagnostic.messages.{MissingCompanionForStatic, StaticFieldsOnlyAllowedInObjects}
 
 /** A transformer that check that requirements of Static fields\methods are implemented:
@@ -39,7 +25,7 @@ import reporting.diagnostic.messages.{MissingCompanionForStatic, StaticFieldsOnl
 class CheckStatic extends MiniPhase {
   import ast.tpd._
 
-  override def phaseName = "checkStatic"
+  override def phaseName = CheckStatic.name
 
   override def transformTemplate(tree: tpd.Template)(implicit ctx: Context): tpd.Tree = {
     val defns = tree.body.collect{case t: ValOrDefDef => t}
@@ -91,3 +77,7 @@ class CheckStatic extends MiniPhase {
     } else tree
   }
 }
+
+object CheckStatic {
+  val name = "checkStatic"
+}

compiler/src/dotty/tools/dotc/typer/RefChecks.scala

@@ -3,9 +3,8 @@ package typer
 
 import transform._
 import core._
-import config._
-import Symbols._, SymDenotations._, Types._, Contexts._, Decorators._, Flags._, Names._, NameOps._
-import StdNames._, Denotations._, Scopes._, Constants.Constant, SymUtils._
+import Symbols._, Types._, Contexts._, Flags._, Names._, NameOps._
+import StdNames._, Denotations._, SymUtils._
 import NameKinds.DefaultGetterName
 import Annotations._
 import util.Positions._
@@ -16,17 +15,17 @@ import Trees._
 import MegaPhase._
 import config.Printers.{checks, noPrinter}
 import util.DotClass
-import scala.util.{Try, Success, Failure}
-import config.{ScalaVersion, NoScalaVersion}
+import scala.util.Failure
+import config.NoScalaVersion
 import Decorators._
 import typer.ErrorReporting._
-import DenotTransformers._
 
 object RefChecks {
   import tpd._
-  import reporting.diagnostic.Message
   import reporting.diagnostic.messages._
 
+  val name = "refchecks"
+
   private val defaultMethodFilter = new NameFilter {
     def apply(pre: Type, name: Name)(implicit ctx: Context): Boolean = name.is(DefaultGetterName)
   }
@@ -910,7 +909,7 @@ class RefChecks extends MiniPhase { thisPhase =>
   import reporting.diagnostic.messages.ForwardReferenceExtendsOverDefinition
   import dotty.tools.dotc.reporting.diagnostic.messages.UnboundPlaceholderParameter
 
-  override def phaseName: String = "refchecks"
+  override def phaseName: String = RefChecks.name
 
   // Needs to run after ElimRepeated for override checks involving varargs methods
   override def runsAfter = Set(ElimRepeated.name)