Skip to content

Commit 7d45958

Browse files
authored
Update comments on TASTy MiMa filters (#19228)
[skip ci]
2 parents a28d1a6 + c83ab27 commit 7d45958

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

project/TastyMiMaFilters.scala

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,10 @@ object TastyMiMaFilters {
2020
ProblemMatcher.make(ProblemKind.MissingTermMember, "scala.math.Big*.underlying"),
2121
ProblemMatcher.make(ProblemKind.NewAbstractMember, "scala.math.ScalaNumericConversions.underlying"),
2222

23-
// Problem: super accessors
23+
// Probably OK: super accessors
2424
// In Scala 3 these accessors are added in the `postyper` phase.
2525
// In Scala 2 these accessors are added in the `superaccessors` phase after typer.
26-
// Are these accessors in the Scala 2 pickles? If so, it implies that TASTy Query/MiMa is ignoring them in Scala 2 but not Scala 3.
27-
// Otherwise, if these are not in the Scala 2 pickles, we might need to remove them when compiling with -Ycompile-scala2-library
26+
// Handle as a special case in `ExtensionMethods`.
2827
ProblemMatcher.make(ProblemKind.NewAbstractMember, "scala.collection.immutable.IndexedSeqOps.superscala$collection$immutable$IndexedSeqOps$$slice"),
2928
ProblemMatcher.make(ProblemKind.NewAbstractMember, "scala.collection.immutable.StrictOptimizedSeqOps.superscala$collection$immutable$StrictOptimizedSeqOps$$sorted"),
3029
ProblemMatcher.make(ProblemKind.NewAbstractMember, "scala.collection.immutable.IndexedSeq.superscala$collection$immutable$IndexedSeq$$*"/* sameElements, canEqual */),
@@ -38,7 +37,7 @@ object TastyMiMaFilters {
3837
ProblemMatcher.make(ProblemKind.NewAbstractMember, "scala.util.control.NoStackTrace.superscala$util$control$NoStackTrace$$fillInStackTrace"),
3938

4039
// TASTy-MiMa bug (probably OK): `private[scala] var` in case class
41-
// This is probably because we can only access the next field from the scala library.
40+
// This member should not have been loaded by TASTy-MiMa.
4241
ProblemMatcher.make(ProblemKind.MissingTermMember, "scala.collection.immutable.::.next$access$1"),
4342

4443
// Probably OK: Problem Missing setter for `protected var`
@@ -60,15 +59,16 @@ object TastyMiMaFilters {
6059
ProblemMatcher.make(ProblemKind.MissingTermMember, "scala.Predef.ne"), // The member scala.Predef.ne with signature (java.lang.Object,java.lang.Object):scala.Boolean does not have a correspondant in current version
6160
ProblemMatcher.make(ProblemKind.MissingTermMember, "scala.Predef.eq"), // The member scala.Predef.eq with signature (java.lang.Object,java.lang.Object):scala.Boolean does not have a correspondant in current version
6261

63-
// Problem: protected lazy val (processThread, (futureThread, futureValue), destroyer) = { ... }
62+
// Probably OK: protected lazy val (processThread, (futureThread, futureValue), destroyer) = { ... }
63+
// None of these can be accessed from user code.
6464
// https://github.com/scala/scala/blob/cff8a9af4da67658d8e1e32f929e1aff03ffa384/src/library/scala/sys/process/ProcessImpl.scala#L99C5-L99C83
6565
ProblemMatcher.make(ProblemKind.IncompatibleKindChange, "scala.sys.process.ProcessImpl.CompoundProcess.destroyer"), // before: lazy val; after: def
6666
ProblemMatcher.make(ProblemKind.IncompatibleKindChange, "scala.sys.process.ProcessImpl.CompoundProcess.futureThread"), // before: lazy val; after: def
6767
ProblemMatcher.make(ProblemKind.IncompatibleKindChange, "scala.sys.process.ProcessImpl.CompoundProcess.processThread"), // before: lazy val; after: def
6868
ProblemMatcher.make(ProblemKind.IncompatibleKindChange, "scala.sys.process.ProcessImpl.CompoundProcess.futureValue"), // before: lazy val; after: def
6969

70-
// Problem?
71-
// https://github.com/scala/scala/blob/2.13.x/src/library/scala/collection/convert/JavaCollectionWrappers.scala#L66-L71
70+
// Probably Ok: defined within a `private[collection]` object
71+
// https://github.com/scala/scala/blob/2.13.x/src/library/scala/collection/convert/JavaCollectionWrappers.scala#L66-L71
7272
ProblemMatcher.make(ProblemKind.MissingTermMember, "scala.collection.convert.JavaCollectionWrappers.IterableWrapperTrait.iterator"), // The member scala.collection.convert.JavaCollectionWrappers.IterableWrapperTrait.iterator with signature ():scala.collection.convert.JavaCollectionWrappers.IteratorWrapper does not have a correspondant in current version
7373

7474
// Problem?

0 commit comments

Comments
 (0)