Merge pull request #12409 from dotty-staging/no-chained-conversion-suggestion

Don't chain conversions when looking for import suggestions

Author: odersky

compiler/src/dotty/tools/dotc/typer/ImportSuggestions.scala

@@ -167,12 +167,15 @@ trait ImportSuggestions:
       allCandidates.map(_.implicitRef.underlyingRef.symbol).toSet
     }
 
+    def testContext(): Context =
+      ctx.fresh.retractMode(Mode.ImplicitsEnabled).setExploreTyperState()
+
     /** Test whether the head of a given instance matches the expected type `pt`,
      *  ignoring any dependent implicit arguments.
      */
     def shallowTest(ref: TermRef): Boolean =
       System.currentTimeMillis < deadLine
-      && inContext(ctx.fresh.setExploreTyperState()) {
+      && inContext(testContext()) {
         def test(pt: Type): Boolean = pt match
           case ViewProto(argType, OrType(rt1, rt2)) =>
             // Union types do not constrain results, since comparison with a union
@@ -209,7 +212,7 @@ trait ImportSuggestions:
         try
           timer.schedule(task, testOneImplicitTimeOut)
           typedImplicit(candidate, expectedType, argument, span)(
-            using ctx.fresh.setExploreTyperState()).isSuccess
+            using testContext()).isSuccess
         finally
           if task.cancel() then // timer task has not run yet
             assert(!ctx.run.isCancelled)

tests/neg/missing-implicit-3.check

@@ -19,9 +19,7 @@ longer explanation available when compiling with `-explain`
   |                                             ^^^^^^^
   |                            value days is not a member of Int, but could be made available as an extension method.
   |
-  |                            One of the following imports might fix the problem:
+  |                            The following import might fix the problem:
   |
   |                              import concurrent.duration.DurationInt
-  |                              import concurrent.duration.DurationLong
-  |                              import concurrent.duration.DurationDouble
   |