Skip to content

Commit bc7c848

Browse files
committed
Don't show extra applies for non-type-forwarder vals
1 parent adde393 commit bc7c848

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

presentation-compiler/src/main/dotty/tools/pc/completions/Completions.scala

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,9 @@ class Completions(
238238
.filter(_.symbol.isAccessibleFrom(denot.info))
239239
constructors -> true
240240

241-
else if shouldAddSnippet && completionMode.is(Mode.Term) && sym.name.isTermName && !sym.is(Flags.Method) && !sym.is(Flags.JavaDefined) then
241+
else if shouldAddSnippet && completionMode.is(Mode.Term) && sym.name.isTermName &&
242+
!sym.is(Flags.JavaDefined) && (sym.isClass || sym.is(Module) || (sym.isField && denot.info.isInstanceOf[TermRef])) then
243+
242244
val constructors = if sym.isAllOf(ConstructorProxyModule) then
243245
sym.companionClass.info.member(nme.CONSTRUCTOR).allSymbols
244246
else

presentation-compiler/test/dotty/tools/pc/tests/completion/CompletionDocSuite.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,6 @@ class CompletionDocSuite extends BaseCompletionSuite:
305305
| }
306306
|}
307307
""".stripMargin,
308-
"""|myNumbers(i: Int): Int
309-
|myNumbers: Vector[Int]
308+
"""|myNumbers: Vector[Int]
310309
|""".stripMargin
311310
)

presentation-compiler/test/dotty/tools/pc/tests/completion/CompletionSuite.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1627,8 +1627,7 @@ class CompletionSuite extends BaseCompletionSuite:
16271627
| val fooBar = List(123)
16281628
| foo@@
16291629
|""".stripMargin,
1630-
"""|fooBar(n: Int): Int
1631-
|fooBar: List[Int]
1630+
"""|fooBar: List[Int]
16321631
|""".stripMargin
16331632
)
16341633

presentation-compiler/test/dotty/tools/pc/tests/completion/CompletionWorkspaceSuite.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -810,7 +810,6 @@ class CompletionWorkspaceSuite extends BaseCompletionSuite:
810810
|}
811811
|""".stripMargin,
812812
"""|fooBar: String
813-
|fooBar(n: Int): Int - test.A
814813
|fooBar: List[Int]
815814
|""".stripMargin,
816815
)

0 commit comments

Comments
 (0)