Address review

Author: liufengyun

compiler/src/dotty/tools/dotc/transform/init/Checking.scala

@@ -347,7 +347,7 @@ object Checking {
 
           case _ =>
             val Summary(pots, effs) = expand(pot1)
-            val Summary(pots2, effs2) = pots.select(sym, pot.source, selectEffect = false)
+            val Summary(pots2, effs2) = pots.select(sym, pot.source, ignoreSelectEffect = false)
             Summary(pots2, effs ++ effs2)
         }
 
@@ -376,7 +376,7 @@ object Checking {
 
           case _ =>
             val Summary(pots, effs) = expand(pot1)
-            val Summary(pots2, effs2) = pots.select(sym, pot.source, selectEffect = false)
+            val Summary(pots2, effs2) = pots.select(sym, pot.source, ignoreSelectEffect = false)
             Summary(pots2, effs ++ effs2)
         }
 

compiler/src/dotty/tools/dotc/transform/init/Potentials.scala

@@ -155,7 +155,15 @@ object Potentials {
 
   extension (pot: Potential) def toPots: Potentials = Potentials.empty + pot
 
-  extension (ps: Potentials) def select (symbol: Symbol, source: Tree, selectEffect: Boolean = true)(using Context): Summary =
+  /** Selection on a set of potentials
+   *
+   *  @param ignoreSelectEffect Where selection effects should be ignored
+   *
+   *  During expansion of potentials, we ignore select effects and only care
+   *  about promotion effects. This is because the selection effects have
+   *  already been checked.
+   */
+  extension (ps: Potentials) def select (symbol: Symbol, source: Tree, ignoreSelectEffect: Boolean = true)(using Context): Summary =
     ps.foldLeft(Summary.empty) { case (summary, pot) =>
       // max potential length
       // TODO: it can be specified on a project basis via compiler options