ClassfileParser: Avoid cycle when accessing companion in inner class lookup

Previously, the call to `info` on the module val could lead to a cycle since the
module val might be in the process of being completed. This commit fixes this by
only using the module class which is all we need to lookup members.

Fixes #15288.
Fixes #14059.

Co-Authored-By: Tom Grigg <[email protected]>

Author: smarter

compiler/src/dotty/tools/dotc/core/classfile/ClassfileParser.scala

@@ -1086,10 +1086,10 @@ class ClassfileParser(
           if (sym == classRoot.symbol)
             staticScope.lookup(name)
           else {
-            var module = sym.companionModule
-            if (!module.exists && sym.isAbsent())
-              module = sym.scalacLinkedClass
-            module.info.member(name).symbol
+            var moduleClass = sym.registeredCompanion
+            if (!moduleClass.exists && sym.isAbsent())
+              moduleClass = sym.scalacLinkedClass
+            moduleClass.info.member(name).symbol
           }
         else if (sym == classRoot.symbol)
           instanceScope.lookup(name)

sbt-test/java-compat/i15288/QueryRequest.java

@@ -0,0 +1,9 @@
+interface CopyableBuilder<B, T> {}
+interface ToCopyableBuilder<B, T> {}
+
+public class QueryRequest implements ToCopyableBuilder<QueryRequest.Builder, QueryRequest> {
+    public static Builder builder() { throw new UnsupportedOperationException(); }
+    public interface Builder extends CopyableBuilder<Builder, QueryRequest> {
+        void build();
+    }
+}

sbt-test/java-compat/i15288/Test.scala

@@ -0,0 +1,2 @@
+class Test:
+  def makeQuery = QueryRequest.builder().build()

sbt-test/java-compat/i15288/build.sbt

@@ -0,0 +1 @@
+scalaVersion := sys.props("plugin.scalaVersion")

sbt-test/java-compat/i15288/test

@@ -0,0 +1,5 @@
+## This could just be a pos test checked by FromTastyTests, but
+## ParallelTesting#compileTastyInDir does not support test with multiple files
+## currently.
+> compile
+> doc