Skip to content

write pipeline TASTy files asynchronously #20101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bishabosha opened this issue Apr 5, 2024 · 0 comments · Fixed by #20153
Closed

write pipeline TASTy files asynchronously #20101

bishabosha opened this issue Apr 5, 2024 · 0 comments · Fixed by #20153

Comments

@bishabosha
Copy link
Member

bishabosha commented Apr 5, 2024

since #19743 was merged, we now have feature completeness for pipelining,

however if pipelining is enabled, we currently block the main compiler thread until all the TASTy files are written, which imposes some performance hit.

for optimum throughput, we should write the files (and notify Zinc) asynchronously.

then at some later point in the compiler (say backend) we can assume the files were likely to have been written by that point, join the thread and report any errors.

@bishabosha bishabosha added the stat:needs triage Every issue needs to have an "area" and "itype" label label Apr 5, 2024
@bishabosha bishabosha self-assigned this Apr 5, 2024
@bishabosha bishabosha added area:tooling itype:enhancement itype:performance and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Apr 5, 2024
@Kordyjan Kordyjan added this to the 3.5.0 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants