From b2e73dc5b513508db94ec7a95440e0d0bd12a306 Mon Sep 17 00:00:00 2001 From: Laure-di Date: Tue, 18 Feb 2025 17:13:15 +0100 Subject: [PATCH 1/3] fix(inference): private endpoint management --- internal/namespaces/inference/v1beta1/helper_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/namespaces/inference/v1beta1/helper_test.go b/internal/namespaces/inference/v1beta1/helper_test.go index 3b8b55cecc..e5ef4b7962 100644 --- a/internal/namespaces/inference/v1beta1/helper_test.go +++ b/internal/namespaces/inference/v1beta1/helper_test.go @@ -5,14 +5,14 @@ import "github.com/scaleway/scaleway-cli/v2/core" func CreateDeploymentPublicEndpoint() core.BeforeFunc { return core.ExecStoreBeforeCmd( "DEPLOYMENT", - "scw inference deployment create node-type=H100 accept-eula=true model-name=meta/llama-2-70b-chat:fp8 -w", + "scw inference deployment create node-type=H100 accept-eula=true model-name=mistral/mistral-7b-instruct-v0.3:bf16 -w", ) } func CreateDeploymentPrivateEndpoint() core.BeforeFunc { return core.ExecStoreBeforeCmd( "DEPLOYMENT", - "scw inference deployment create node-type=H100 accept-eula=true model-name=meta/llama-2-70b-chat:fp8 endpoints.0.private-network.private-network-id={{ .PN.ID }} -w", + "scw inference deployment create node-type=H100 accept-eula=true model-name=mistral/mistral-7b-instruct-v0.3:bf16 endpoints.0.private-network.private-network-id={{ .PN.ID }} -w", ) } From 327c1b152003e1400734d8a8100e69929b0ca8a4 Mon Sep 17 00:00:00 2001 From: Laure-di Date: Wed, 19 Feb 2025 09:30:47 +0100 Subject: [PATCH 2/3] fix(inference): attach private network --- .../inference/v1beta1/custom_endpoint.go | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/internal/namespaces/inference/v1beta1/custom_endpoint.go b/internal/namespaces/inference/v1beta1/custom_endpoint.go index 95641460f9..d7b1421130 100644 --- a/internal/namespaces/inference/v1beta1/custom_endpoint.go +++ b/internal/namespaces/inference/v1beta1/custom_endpoint.go @@ -32,15 +32,20 @@ func endpointCreateBuilder(c *core.Command) *core.Command { createEndpointCustomRequest := argsI.(*createEndpointRequestCustom) createEndpointreq := createEndpointCustomRequest.CreateEndpointRequest endpoint := createEndpointCustomRequest.Endpoint + endpointToCreate := inference.EndpointSpec{ + Public: nil, + PrivateNetwork: nil, + DisableAuth: endpoint.DisableAuth, + } if endpoint.IsPublic { publicEndpoint := &inference.EndpointSpecPublic{} - endpointToCreate := inference.EndpointSpec{ - Public: publicEndpoint, - PrivateNetwork: nil, - DisableAuth: endpoint.DisableAuth, - } - createEndpointreq.Endpoint = &endpointToCreate + endpointToCreate.Public = publicEndpoint + + } + if endpoint.PrivateNetwork != nil && endpoint.PrivateNetwork.PrivateNetworkID != "" { + endpointToCreate.PrivateNetwork = &inference.EndpointSpecPrivateNetwork{PrivateNetworkID: endpoint.PrivateNetwork.PrivateNetworkID} } + createEndpointreq.Endpoint = &endpointToCreate return runner(ctx, createEndpointreq) } From 3a627d7645045ed32fc10104b68a2b14c6620565 Mon Sep 17 00:00:00 2001 From: Laure-di Date: Wed, 19 Feb 2025 09:37:22 +0100 Subject: [PATCH 3/3] fix golangci --- internal/namespaces/inference/v1beta1/custom_endpoint.go | 1 - 1 file changed, 1 deletion(-) diff --git a/internal/namespaces/inference/v1beta1/custom_endpoint.go b/internal/namespaces/inference/v1beta1/custom_endpoint.go index d7b1421130..f204591113 100644 --- a/internal/namespaces/inference/v1beta1/custom_endpoint.go +++ b/internal/namespaces/inference/v1beta1/custom_endpoint.go @@ -40,7 +40,6 @@ func endpointCreateBuilder(c *core.Command) *core.Command { if endpoint.IsPublic { publicEndpoint := &inference.EndpointSpecPublic{} endpointToCreate.Public = publicEndpoint - } if endpoint.PrivateNetwork != nil && endpoint.PrivateNetwork.PrivateNetworkID != "" { endpointToCreate.PrivateNetwork = &inference.EndpointSpecPrivateNetwork{PrivateNetworkID: endpoint.PrivateNetwork.PrivateNetworkID}