From 57d539292d12839e53bb94ed08390256334e9150 Mon Sep 17 00:00:00 2001 From: Koichi Murase Date: Sun, 26 Dec 2021 06:34:22 +0900 Subject: [PATCH] fix(man,info): remove ineffective "_expand" calls The function "_expand" processes "cur" that begins with a tilde, which is actually already processed by earlier codes in these completions. Thus "_expand" will never see "cur" starting with a tilde there. The earlier codes processing the tilde were introduced in commit 1b85a1b. The calls of "_expand" was moved after the code in commit add4e3c, for which we forgot the background unfortunately. We here just remove the calls of "_expand". --- completions/info | 2 -- completions/man | 2 -- 2 files changed, 4 deletions(-) diff --git a/completions/info b/completions/info index 549abc41eb3..7a179e63c30 100644 --- a/completions/info +++ b/completions/info @@ -47,8 +47,6 @@ _info() infopath=$INFOPATH fi - _expand || return - infopath=$infopath: if [[ -n $cur ]]; then infopath="${infopath//://$cur* }" diff --git a/completions/man b/completions/man index 037a715fdb6..94935753c25 100644 --- a/completions/man +++ b/completions/man @@ -75,8 +75,6 @@ _man() # shellcheck disable=SC2053 [[ $prev == $mansect ]] && sect=$prev || sect='*' - _expand || return - manpath=$manpath: if [[ -n $cur ]]; then manpath="${manpath//://*man$sect/$cur* } ${manpath//://*cat$sect/$cur* }"