Skip to content

Commit 8925c81

Browse files
committed
Fix the valid/covered lines and branches in the cobertura report - they were swapped
1 parent 9ff7e25 commit 8925c81

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

scalac-scoverage-plugin/src/main/scala/scoverage/report/CoberturaXmlWriter.scala

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ class CoberturaXmlWriter(sourceDirectories: Seq[File], outputDir: File) extends
1212
def this (baseDir: File, outputDir: File) {
1313
this(Seq(baseDir), outputDir)
1414
}
15-
15+
1616
def format(double: Double): String = "%.2f".format(double)
1717

1818
def write(coverage: Coverage): Unit = {
1919
val file = new File(outputDir, "cobertura.xml")
20-
IOUtils.writeToFile(file, "<?xml version=\"1.0\"?>\n<!DOCTYPE coverage SYSTEM \"https://github.com/raw/cobertura/cobertura/master/cobertura/src/site/htdocs/xml/coverage-04.dtd\">\n" +
20+
IOUtils.writeToFile(file, "<?xml version=\"1.0\"?>\n<!DOCTYPE coverage SYSTEM \"https://github.com/raw/cobertura/cobertura/master/cobertura/src/site/htdocs/xml/coverage-04.dtd\">\n" +
2121
new PrettyPrinter(120, 4).format(xml(coverage)))
2222
}
2323

@@ -75,10 +75,10 @@ class CoberturaXmlWriter(sourceDirectories: Seq[File], outputDir: File) extends
7575

7676
def xml(coverage: Coverage): Node = {
7777
<coverage line-rate={format(coverage.statementCoverage)}
78-
lines-covered={coverage.statementCount.toString}
79-
lines-valid={coverage.invokedStatementCount.toString}
80-
branches-covered={coverage.branchCount.toString}
81-
branches-valid={coverage.invokedBranchesCount.toString}
78+
lines-valid={coverage.statementCount.toString}
79+
lines-covered={coverage.invokedStatementCount.toString}
80+
branches-valid={coverage.branchCount.toString}
81+
branches-covered={coverage.invokedBranchesCount.toString}
8282
branch-rate={format(coverage.branchCoverage)}
8383
complexity="0"
8484
version="1.0"

0 commit comments

Comments
 (0)