Skip to content

Release new version with working exclusion options #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
avdv opened this issue Aug 26, 2019 · 2 comments
Closed

Release new version with working exclusion options #278

avdv opened this issue Aug 26, 2019 · 2 comments

Comments

@avdv
Copy link

avdv commented Aug 26, 2019

I am not sure whether comments to arbitrary commits are working so great to draw any attention, so I am repeating my request here as a new issue:

Currently, release 1.4.0 is broken regarding the usage of any exclusion settings. This has been fixed a while ago in commit ddf856d.

Can we get a new release with this fix? I just spent some time debugging why my coverageExcludedFiles SBT setting would not be taken into account... 🥺 🙏

Thanks!

@avdv
Copy link
Author

avdv commented Aug 28, 2019

I had a look at the code again and I just realized, that the bug only renders the first regex non-operational. I work-around by prepending a never-matching regex to the list of the regexs I am interested in:

coverageExcludedFiles := "$:;" + coverageExcludedFiles.value

@ckipp01
Copy link
Member

ckipp01 commented Aug 31, 2021

Since there was a release since then I'm going to go ahead and close this. If there is still an issue here, please do comment back.

@ckipp01 ckipp01 closed this as completed Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants