Skip to content

Commit b5128c0

Browse files
Tonymac32ayufan
authored andcommitted
tonymac32: rk3328: sdmmc0 drive level change to 8mA (torvalds#38)
SD Instability has been a commonly reported issue on RK3328 boards, the Rockchip default drive level of 4mA is unable to reliably drive any significant capacitive load (even within SD card specification) at 50MHz high speed, especially with 3.3V signalling. Further testing may indicate a need for 12mA, but for now this patch has been shown to resolve SD boot and stability issues on several boards, including Rock64 and a Renegade. The issue spanning multiple boards is why I didn't simply override the settings in the board specific DTS. It may also be important to note the ASUS Tinker Board (RK3288) uses 8mA drive levels. This may be worth evaluating for RK3399 as well.
1 parent f13a8a9 commit b5128c0

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

arch/arm64/boot/dts/rockchip/rk3328.dtsi

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2053,35 +2053,35 @@
20532053
sdmmc0 {
20542054
sdmmc0_clk: sdmmc0-clk {
20552055
rockchip,pins =
2056-
<1 RK_PA6 RK_FUNC_1 &pcfg_pull_none_4ma>;
2056+
<1 RK_PA6 RK_FUNC_1 &pcfg_pull_none_8ma>;
20572057
};
20582058

20592059
sdmmc0_cmd: sdmmc0-cmd {
20602060
rockchip,pins =
2061-
<1 RK_PA4 RK_FUNC_1 &pcfg_pull_up_4ma>;
2061+
<1 RK_PA4 RK_FUNC_1 &pcfg_pull_up_8ma>;
20622062
};
20632063

20642064
sdmmc0_dectn: sdmmc0-dectn {
20652065
rockchip,pins =
2066-
<1 RK_PA5 RK_FUNC_1 &pcfg_pull_up_4ma>;
2066+
<1 RK_PA5 RK_FUNC_1 &pcfg_pull_up_8ma>;
20672067
};
20682068

20692069
sdmmc0_wrprt: sdmmc0-wrprt {
20702070
rockchip,pins =
2071-
<1 RK_PA7 RK_FUNC_1 &pcfg_pull_up_4ma>;
2071+
<1 RK_PA7 RK_FUNC_1 &pcfg_pull_up_8ma>;
20722072
};
20732073

20742074
sdmmc0_bus1: sdmmc0-bus1 {
20752075
rockchip,pins =
2076-
<1 RK_PA0 RK_FUNC_1 &pcfg_pull_up_4ma>;
2076+
<1 RK_PA0 RK_FUNC_1 &pcfg_pull_up_8ma>;
20772077
};
20782078

20792079
sdmmc0_bus4: sdmmc0-bus4 {
20802080
rockchip,pins =
2081-
<1 RK_PA0 RK_FUNC_1 &pcfg_pull_up_4ma>,
2082-
<1 RK_PA1 RK_FUNC_1 &pcfg_pull_up_4ma>,
2083-
<1 RK_PA2 RK_FUNC_1 &pcfg_pull_up_4ma>,
2084-
<1 RK_PA3 RK_FUNC_1 &pcfg_pull_up_4ma>;
2081+
<1 RK_PA0 RK_FUNC_1 &pcfg_pull_up_8ma>,
2082+
<1 RK_PA1 RK_FUNC_1 &pcfg_pull_up_8ma>,
2083+
<1 RK_PA2 RK_FUNC_1 &pcfg_pull_up_8ma>,
2084+
<1 RK_PA3 RK_FUNC_1 &pcfg_pull_up_8ma>;
20852085
};
20862086

20872087
sdmmc0_gpio: sdmmc0-gpio {

0 commit comments

Comments
 (0)