fixed issue where foreign characters break data integrity check (microsoft#2078)

raen79 · Sourabh Debnath · commit 0163acafea7c · 2022-05-02T10:36:44.000+05:30
diff --git a/ios/CodePush/CodePushUpdateUtils.m b/ios/CodePush/CodePushUpdateUtils.m
@@ -93,7 +93,7 @@ + (NSString *)computeFinalHashFromManifest:(NSMutableArray *)manifest
     // The JSON serialization turns path separators into "\/", e.g. "CodePush\/assets\/image.png"
     manifestString = [manifestString stringByReplacingOccurrencesOfString:@"\\/"
                                                                withString:@"/"];
-    return [self computeHashForData:[NSData dataWithBytes:manifestString.UTF8String length:manifestString.length]];
+    return [self computeHashForData:[NSData dataWithBytes:manifestString.UTF8String length:[manifestString lengthOfBytesUsingEncoding:NSUTF8StringEncoding]]];
 }
 
 + (NSString *)computeHashForData:(NSData *)inputData

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ + (NSString )computeFinalHashFromManifest:(NSMutableArray )manifest`
`93`	`93`	`// The JSON serialization turns path separators into "\/", e.g. "CodePush\/assets\/image.png"`
`94`	`94`	`manifestString = [manifestString stringByReplacingOccurrencesOfString:@"\\/"`
`95`	`95`	`withString:@"/"];`
`96`		`- return [self computeHashForData:[NSData dataWithBytes:manifestString.UTF8String length:manifestString.length]];`
	`96`	`+ return [self computeHashForData:[NSData dataWithBytes:manifestString.UTF8String length:[manifestString lengthOfBytesUsingEncoding:NSUTF8StringEncoding]]];`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`+ (NSString )computeHashForData:(NSData )inputData`