Skip to content

Commit aae2ea5

Browse files
NazariiDenhamask-pp0xmountaintop
authored
feat: include fee vault address in trace api result (#208)
* include fee vault address in trace api result * use fee vault instead of coinbase if exists * retrigger checks * Update api_blocktrace_test.go --------- Co-authored-by: maskpp <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]>
1 parent 7c3657b commit aae2ea5

File tree

2 files changed

+18
-7
lines changed

2 files changed

+18
-7
lines changed

eth/tracers/api_blocktrace.go

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,14 @@ func (api *API) createTraceEnv(ctx context.Context, config *TraceConfig, block *
9494
}
9595

9696
// get coinbase
97-
coinbase, err := api.backend.Engine().Author(block.Header())
98-
if err != nil {
99-
return nil, err
97+
var coinbase common.Address
98+
if api.backend.ChainConfig().FeeVaultAddress != nil {
99+
coinbase = *api.backend.ChainConfig().FeeVaultAddress
100+
} else {
101+
coinbase, err = api.backend.Engine().Author(block.Header())
102+
if err != nil {
103+
return nil, err
104+
}
100105
}
101106

102107
env := &traceEnv{
@@ -127,6 +132,7 @@ func (api *API) createTraceEnv(ctx context.Context, config *TraceConfig, block *
127132
}
128133
env.Proofs[key] = wrappedProof
129134
}
135+
130136
return env, nil
131137
}
132138

eth/tracers/api_blocktrace_test.go

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -180,10 +180,15 @@ func checkStructLogs(t *testing.T, expect []*txTraceResult, actual []*types.Exec
180180
}
181181

182182
func checkCoinbase(t *testing.T, b *testBackend, wrapper *types.AccountWrapper) {
183-
header, err := b.HeaderByNumber(context.Background(), 1)
184-
assert.NoError(t, err)
185-
coinbase, err := b.engine.Author(header)
186-
assert.NoError(t, err)
183+
var coinbase common.Address
184+
if b.chainConfig.FeeVaultAddress != nil {
185+
coinbase = *b.chainConfig.FeeVaultAddress
186+
} else {
187+
header, err := b.HeaderByNumber(context.Background(), 1)
188+
assert.NoError(t, err)
189+
coinbase, err = b.engine.Author(header)
190+
assert.NoError(t, err)
191+
}
187192
assert.Equal(t, true, coinbase.String() == wrapper.Address.String())
188193
}
189194

0 commit comments

Comments
 (0)