Skip to content

Commit 541e98a

Browse files
committed
delete extra client in relayer1
1 parent 16576b6 commit 541e98a

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

bridge/l1/backend.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ func New(ctx context.Context, cfg *config.L1Config, orm database.OrmFactory) (*B
2626
return nil, err
2727
}
2828

29-
relayer, err := NewLayer1Relayer(ctx, client, int64(cfg.Confirmations), orm, cfg.RelayerConfig)
29+
relayer, err := NewLayer1Relayer(ctx, int64(cfg.Confirmations), orm, cfg.RelayerConfig)
3030
if err != nil {
3131
return nil, err
3232
}

bridge/l1/relayer.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import (
1111
"github.com/scroll-tech/go-ethereum/accounts/abi"
1212
"github.com/scroll-tech/go-ethereum/common"
1313
"github.com/scroll-tech/go-ethereum/crypto"
14-
"github.com/scroll-tech/go-ethereum/ethclient"
1514
"github.com/scroll-tech/go-ethereum/log"
1615

1716
"scroll-tech/database/orm"
@@ -29,7 +28,6 @@ import (
2928
// @todo It's better to be triggered by watcher.
3029
type Layer1Relayer struct {
3130
ctx context.Context
32-
client *ethclient.Client
3331
sender *sender.Sender
3432

3533
db orm.L1MessageOrm
@@ -43,7 +41,7 @@ type Layer1Relayer struct {
4341
}
4442

4543
// NewLayer1Relayer will return a new instance of Layer1RelayerClient
46-
func NewLayer1Relayer(ctx context.Context, ethClient *ethclient.Client, l1ConfirmNum int64, db orm.L1MessageOrm, cfg *config.RelayerConfig) (*Layer1Relayer, error) {
44+
func NewLayer1Relayer(ctx context.Context, l1ConfirmNum int64, db orm.L1MessageOrm, cfg *config.RelayerConfig) (*Layer1Relayer, error) {
4745
l2MessengerABI, err := bridge_abi.L2MessengerMetaData.GetAbi()
4846
if err != nil {
4947
log.Warn("new L2MessengerABI failed", "err", err)
@@ -59,7 +57,6 @@ func NewLayer1Relayer(ctx context.Context, ethClient *ethclient.Client, l1Confir
5957

6058
return &Layer1Relayer{
6159
ctx: ctx,
62-
client: ethClient,
6360
sender: sender,
6461
db: db,
6562
l2MessengerABI: l2MessengerABI,

bridge/l1/relayer_test.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import (
44
"context"
55
"testing"
66

7-
"github.com/scroll-tech/go-ethereum/ethclient"
87
"github.com/stretchr/testify/assert"
98

109
"scroll-tech/database/migrate"
@@ -20,10 +19,7 @@ func testCreateNewL1Relayer(t *testing.T) {
2019
assert.NoError(t, migrate.ResetDB(db.GetDB().DB))
2120
defer db.Close()
2221

23-
client, err := ethclient.Dial(l1gethImg.Endpoint())
24-
assert.NoError(t, err)
25-
26-
relayer, err := NewLayer1Relayer(context.Background(), client, 1, db, cfg.L2Config.RelayerConfig)
22+
relayer, err := NewLayer1Relayer(context.Background(), 1, db, cfg.L2Config.RelayerConfig)
2723
assert.NoError(t, err)
2824
defer relayer.Stop()
2925

0 commit comments

Comments
 (0)