-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Linux 802.1Q support #2091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux 802.1Q support #2091
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2091 +/- ##
==========================================
+ Coverage 87.28% 87.32% +0.03%
==========================================
Files 199 199
Lines 45094 45318 +224
==========================================
+ Hits 39361 39572 +211
- Misses 5733 5746 +13
|
Cool PR! Could you add unit tests like done in |
I wasn't even able to try it out locally -_- If someone can figure it out I'd really appreciate it |
I am still trying to find a way to test it. |
I tested it against two VMs in the VLAN, and it works as expected. This PR:
master
|
I finally managed to find a way to test this PR locally. Hopefully this will also work on Travis.
|
See #969
This only works with Python 3
IMH we shouldn't bother supporting Python 2.7. I'm against implementing the whole shabang of
ctypes
calls to support something which EOL is so soon.