Merge pull request #252 from MVrachev/fix-failing-tuf-tests

Throw exception on empty filepath in create_folder

Author: joshuagl

securesystemslib/storage.py

@@ -254,10 +254,6 @@ def getsize(self, filepath):
 
 
   def create_folder(self, filepath):
-    # If called with an empty string, return immediately
-    if not filepath:
-      return
-
     try:
       os.makedirs(filepath)
     except OSError as e:
@@ -266,6 +262,9 @@ def create_folder(self, filepath):
       # silently ignore.
       if e.errno == errno.EEXIST:
         pass
+      elif e.errno == errno.ENOENT and not filepath:
+        raise securesystemslib.exceptions.StorageError(
+            "Can't create a folder with an empty filepath!")
       else:
         raise securesystemslib.exceptions.StorageError(
             "Can't create folder at %s" % filepath)

tests/test_storage.py

@@ -65,6 +65,9 @@ def test_exceptions(self):
     self.assertRaises(securesystemslib.exceptions.StorageError,
         self.storage_backend.create_folder, '/none/existent/path')
 
+    self.assertRaises(securesystemslib.exceptions.StorageError,
+        self.storage_backend.create_folder, '')
+
     self.assertRaises(securesystemslib.exceptions.StorageError,
         self.storage_backend.list_folder, '/none/existent/path')
 
@@ -97,6 +100,3 @@ def test_folders(self):
         fi.write(leaf.encode('utf-8'))
     found_leaves = self.storage_backend.list_folder(folder)
     self.assertListEqual(leaves, sorted(found_leaves))
-
-    # Test trying to create a folder with an empty string
-    self.storage_backend.create_folder('')