Skip to content

Commit 2bad1fa

Browse files
forstisabellapwseg
andauthored
Apply suggestions from code review
Co-authored-by: pwseg <[email protected]>
1 parent d5ddd4b commit 2bad1fa

File tree

7 files changed

+7
-7
lines changed

7 files changed

+7
-7
lines changed

src/connections/destinations/catalog/amazon-personalize/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@ Segment will need to be able to call ("invoke") your Lambda in order to process
642642
To create an IAM policy:
643643
1. Sign in to the [Identity and Access Management (IAM) console](https://console.aws.amazon.com/iam/){:target="_blank"} and follow these instructions to [Create an IAM policy](http://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_create.html){:target="_blank"} to allow Segment permission to invoke your Lambda function.
644644
645-
2. Select **Create Policy from JSON** and use the following template policy in the `Policy Document` field. Be sure to change the `{region}`, `{account-id}` and `{function-names}` with the applicable values. Here's example of a Lambda ARN `arn:aws:lambda:us-west-2:355207333203:function:``my-example-function`. You can put in a placeholder ARN for now, as you will need to come back to this step to update with the ARN of your Lambda once that's been created.
645+
2. Select **Create Policy from JSON** and use the following template policy in the `Policy Document` field. Be sure to change the `{region}`, `{account-id}` and `{function-names}` with the applicable values. Here's an example of a Lambda ARN `arn:aws:lambda:us-west-2:355207333203:function:``my-example-function`. You can put in a placeholder ARN for now, as you will need to come back to this step to update with the ARN of your Lambda once that's been created.
646646
647647
```json
648648
{

src/connections/destinations/catalog/optimizely-full-stack/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ If you want to use Optimizely's [notification listeners](https://docs.developers
127127
When implementing Optimizely using cloud-mode, Segment will map `track` events to Optimizely `track` events on our servers and deliver the data to your Optimizely project as usual.
128128

129129
> warning "Optimizely SDKs v1.x or v2.x require matching `attributes` objects for correct attribution"
130-
> If you use Optimizely SDKs v1.x or v2.x and use any `activate` or `isFeatureEnabled` calls, the `attributes` object for each user must match the `attributes` object passed to any `track` calls for that user id so that it can be correctly attributed on the Optimizely results page.
130+
> If you use Optimizely SDKs v1.x or v2.x and use any `activate` or `isFeatureEnabled` calls, the `attributes` object for each user must match the `attributes` object passed to any Track calls for that user id so that it can be correctly attributed on the Optimizely results page.
131131
132132
If you are using Optimizely SDKs v3+, [Easy Event Tracking](https://blog.optimizely.com/2019/02/26/introducing-easy-event-tracking-the-easier-way-to-understand-and-optimize-the-customer-journey/){:target="_blank"} is enabled by default for decision events. Set up does not require maintaining the attributes of a user as long as the user id stays the same between Optimizely `activate` and `isFeatureEnabled` calls and Segment `track` calls to have Optimizely `metrics` populated in the Optimizely results page. If you would like to segment your Optimizely results by user `attribute`, then make sure the `attributes` passed in for the `activate` and `isFeatureEnabled` calls match the `attributes` passed in for the `track` calls for that user id.
133133

src/connections/destinations/catalog/optimizely-web/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ If you're sending your experiment data to Google Analytics in the form of `track
150150
6. Finally, define any [`events`](https://docs.developers.optimizely.com/full-stack/docs/create-events){:target="_blank"} and [`attributes`](https://docs.developers.optimizely.com/full-stack/docs/define-attributes){:target="_blank"} in your Optimizely dashboard, and to associate `metrics` with the appropriate Optimizely Experiments. Segment maps `track` event names to Optimizely `eventName` - the `eventName` corresponds to an experiment `metric`.
151151

152152
> warning "Optimizely SDKs v1.x or v2.x require matching `attributes` objects for correct attribution"
153-
> If you use Optimizely SDKs v1.x or v2.x and use any `activate` or `isFeatureEnabled` calls, the `attributes` object for each user must match the `attributes` object passed to any `track` calls for that user id so that it can be correctly attributed on the Optimizely results page.
153+
> If you use Optimizely SDKs v1.x or v2.x and use any `activate` or `isFeatureEnabled` calls, the `attributes` object for each user must match the `attributes` object passed to any Track calls for that user id so that it can be correctly attributed on the Optimizely results page.
154154
155155
If you are using Optimizely SDKs v3+ or the React SDK, [Easy Event Tracking](https://blog.optimizely.com/2019/02/26/introducing-easy-event-tracking-the-easier-way-to-understand-and-optimize-the-customer-journey/){:target="_blank"} is enabled by default for decision events. Set up does not require maintaining the attributes of a user as long as the user id stays the same between Optimizely `activate` and `isFeatureEnabled` calls and Segment `track` calls to have Optimizely `metrics` populated in the Optimizely results page. If you would like to segment your Optimizely results by user `attribute`, then make sure the `attributes` passed in for the `activate` and `isFeatureEnabled` calls match the `attributes` passed in for the `track` calls for that user id.
156156

src/connections/destinations/catalog/recombee-ai/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ versions:
1212
---
1313

1414
[Recombee](https://recombee.com/?utm_source=segmentio&utm_medium=docs&utm_campaign=partners){:target="_blank”} is a Recommender as a Service that can use your data to provide the most accurate recommendations of content or products for your users.
15-
Use this Segment destination to send your interaction data views, purchases, plays, etc.) to Recombee.
15+
Use this Segment destination to send your interaction data (views, purchases, plays, and so on) to Recombee.
1616

1717
This destination is maintained by Recombee. For any issues with the destination, [contact the Recombee Support team](mailto:[email protected]).
1818

src/connections/sources/catalog/libraries/mobile/android/quickstart.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ Ensure that the necessary permissions are declared in your application's `Androi
8080
> success ""
8181
> For any of the different methods described in this quickstart, you can replace the properties and traits in the code samples with variables that represent the data collected.
8282
83-
The `identify` method is one of Segment's core API methods. It's how you tie one of your users and their actions to a recognizable userId. It also lets you record traits about the user, like their email, name, account type, etc. You can read more about it in the [identify reference](/docs/connections/sources/catalog/libraries/mobile/android#identify).
83+
The Identify call is one of Segment's core API methods. It's how you tie one of your users and their actions to a recognizable `userId`. It also lets you record traits about the user, like their email, name, and account type. You can read more about it in the [Identify reference](/docs/connections/sources/catalog/libraries/mobile/android#identify).
8484

8585
When and where you call `identify` depends on how your users are authenticated, but doing it in the `onCreate` method of your [Application](http://developer.android.com/reference/android/app/Application.html) class would be most common, as long as you know who your user is. If your user is still anonymous, you should skip this part and we'll attribute the subsequent events to an `anonymousId` instead.
8686

src/connections/sources/catalog/libraries/mobile/ios/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -836,7 +836,7 @@ The same value for IDFA will used across all (device and cloud-mode) integration
836836
837837
838838
> success ""
839-
> Analytics-ios can continue to collect events without the IDFA until a user is prompted and only upon user consent the `advertisingId` field is added to the event payload.
839+
> Analytics-iOS can continue to collect events without the IDFA until a user is prompted and only upon user consent the `advertisingId` field is added to the event payload.
840840
841841
Ad-tracking affects two keys under the `context` object of every event:
842842

src/getting-started/02-simple-install.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ analytics.identify(' {{user.id}} ', {
112112
<br>
113113
With that call in your page footer, you successfully identify every user that visits your site.
114114
<br><br>
115-
> info ""
115+
> success ""
116116
> You've completed a basic CRM set up. Return to the Segment app to enable Salesforce, Intercom, or your CRM system of choice and Segment starts sending all of your user data to it.
117117
118118
<br>

0 commit comments

Comments
 (0)