Skip to content
This repository was archived by the owner on Aug 20, 2020. It is now read-only.

Commit 9e40b55

Browse files
author
Matt Bernier
authored
Merge pull request #34 from jeffgerlach/create_pull_request_template
Add pull request template
2 parents 48f06aa + 9b3e450 commit 9e40b55

File tree

1 file changed

+31
-0
lines changed

1 file changed

+31
-0
lines changed

.github/PULL_REQUEST_TEMPLATE

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
<!--
2+
Please explain WHAT you changed and WHY.
3+
4+
The title should be descriptive, for example:
5+
6+
* *Fixed a typo in the apikeypermissions.md page*
7+
* *Added the maximum number of domain whitelabels you can create to domains.md*
8+
* *Fixing the number of days a batch id is valid in scheduling_parameters.md*
9+
10+
If this PR fixes an issue, please reference the issue number as well.
11+
12+
Fill out this form in the body:
13+
-->
14+
15+
**Description of the change**:
16+
17+
**Reason for the change**:
18+
19+
**Link to original source**:
20+
21+
### Checklist
22+
23+
Make sure all of these items are complete, or else the PR will be ineligible for a code review.
24+
25+
- [ ] Code passes all existing [tests](https://github.com/sendgrid/nodejs-http-client/tree/master/test)
26+
- [ ] Any new functionality added includes new unit tests in [`test/test.js`](https://github.com/sendgrid/nodejs-http-client/tree/master/test/test.js)
27+
- [ ] Create or update example code to show the new functionality in action.
28+
- [ ] All code, branch, and git naming and style conventions are followed (see [`CONTRIBUTING.md`](https://github.com/sendgrid/nodejs-http-client/blob/master/CONTRIBUTING.md#style-guidelines--naming-conventions))
29+
- [ ] Feature branch has been rebased off of the latest `master` branch. ( see [`CONTRIBUTING.md`](https://github.com/sendgrid/nodejs-http-client/blob/master/CONTRIBUTING.md#creating-a-pull-request) ).
30+
31+
If you have questions, please send an email [Sendgrid](mailto:[email protected]), or file a Github Issue in this repository.

0 commit comments

Comments
 (0)