You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 20, 2020. It is now read-only.
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+44-49Lines changed: 44 additions & 49 deletions
Original file line number
Diff line number
Diff line change
@@ -1,14 +1,28 @@
1
-
Hello! Thank you for choosing to help contribute to the nodejs-http-client project. There are many ways you can contribute and help is always welcome.
2
-
1
+
Hello! Thank you for choosing to help contribute to one of the SendGrid open source libraries. There are many ways you can contribute and help is always welcome. We simply ask that you follow the following contribution policies.
2
+
3
+
-[CLAs and CCLAs](#cla)
4
+
-[Roadmap & Milestones](#roadmap)
5
+
-[Feature Request](#feature_request)
6
+
-[Submit a Bug Report](#submit_a_bug_report)
7
+
-[Improvements to the Codebase](#improvements_to_the_codebase)
8
+
-[Understanding the Code Base](#understanding_the_codebase)
-[Creating a Pull Request](#creating_a_pull_request)
12
+
13
+
<aname="roadmap"></a>
3
14
We use [Milestones](https://github.com/sendgrid/nodejs-http-client/milestones) to help define current roadmaps, please feel free to grab an issue from the current milestone. Please indicate that you have begun work on it to avoid collisions. Once a PR is made, community review, comments, suggestions and additional PRs are welcomed and encouraged.
4
15
5
-
*[Feature Request](#feature_request)
6
-
*[Submit a Bug Report](#submit_a_bug_report)
7
-
*[Improvements to the Codebase](#improvements_to_the_codebase)
8
-
*[Understanding the Code Base](#understanding_the_codebase)
*[Creating a Pull Request](#creating_a_pull_request)
16
+
<aname="cla"></a>
17
+
## CLAs and CCLAs
18
+
19
+
Before you get started, SendGrid requires that a SendGrid Contributor License Agreement (CLA) or a SendGrid Company Contributor Licensing Agreement (CCLA) be filled out by every contributor to a SendGrid open source project.
20
+
21
+
Our goal with the CLA and CCLA is to clarify the rights of our contributors and reduce other risks arising from inappropriate contributions. The CLA also clarifies the rights SendGrid holds in each contribution and helps to avoid misunderstandings over what rights each contributor is required to grant to SendGrid when making a contribution. In this way the CLA and CCLA encourage broad participation by our open source community and help us build strong open source projects, free from any individual contributor withholding or revoking rights to any contribution.
22
+
23
+
SendGrid does not merge a pull request made against a SendGrid open source project until that pull request is associated with a signed CLA (or CCLA). Copies of the CLA and CCLA are available [here](https://drive.google.com/a/sendgrid.com/file/d/0B0PlcM9qA91LN2VEUTJWU2RIVXc/view).
24
+
25
+
You may submit your completed [CLA or CCLA](https://drive.google.com/a/sendgrid.com/file/d/0B0PlcM9qA91LN2VEUTJWU2RIVXc/view) to SendGrid at [[email protected]](mailto:[email protected]). SendGrid will then confirm you are ready to begin making contributions.
12
26
13
27
There are a few ways to contribute, which we'll enumerate below:
14
28
@@ -37,49 +51,28 @@ Before you decide to create a new issue, please try the following:
37
51
38
52
### Please use our Bug Report Template
39
53
40
-
In order to make the process easier, we've included a sample bug report template (borrowed from [Ghost](https://github.com/TryGhost/Ghost/)). The template uses [GitHub flavored markdown](https://help.github.com/articles/github-flavored-markdown/) for formatting.
41
-
42
-
```
43
-
Short and descriptive example bug report title
44
-
45
-
#### Issue Summary
46
-
47
-
A summary of the issue and the environment in which it occurs. If suitable, include the steps required to reproduce the bug. Please feel free to include screenshots, screencasts, code examples.
48
-
49
-
50
-
#### Steps to Reproduce
51
-
52
-
1. This is the first step
53
-
2. This is the second step
54
-
3. Further steps, etc.
55
-
56
-
Any other information you want to share that is relevant to the issue being reported. Especially, why do you consider this to be a bug? What do you expect to happen instead?
In order to make the process easier, we've included a [sample bug report template](https://github.com/sendgrid/nodejs-http-client/.github/ISSUE_TEMPLATE) (borrowed from [Ghost](https://github.com/TryGhost/Ghost/)). The template uses [GitHub flavored markdown](https://help.github.com/articles/github-flavored-markdown/) for formatting.
63
55
64
56
<aname="improvements_to_the_codebase"></a>
65
57
## Improvements to the Codebase
66
58
67
-
We welcome direct contributions to the rest code base. Thank you!
59
+
We welcome direct contributions to the nodejs-http-client code base. Thank you!
68
60
69
61
### Development Environment ###
70
62
71
-
#### Install and run locally ####
63
+
#### Install and Run Locally ####
72
64
73
65
##### Prerequisites #####
74
66
75
-
* Node.js 0.10 and up
76
-
* Please see [package.json](https://github.com/sendgrid/nodejs-http-client/blob/master/package.json)
67
+
- Node.js 0.10 and up
68
+
- Please see [package.json](https://github.com/sendgrid/nodejs-http-client/blob/master/package.json)
@@ -104,7 +103,7 @@ Working examples that demonstrate usage.
104
103
105
104
**client.js**
106
105
107
-
There is a object to hold both the request and response to the API server.
106
+
There is a object to hold both the request and response to the API server.
108
107
109
108
The main function that does the heavy lifting (and external entry point) is `API`.
110
109
@@ -113,7 +112,7 @@ The main function that does the heavy lifting (and external entry point) is `API
113
112
114
113
All PRs require passing tests before the PR will be reviewed.
115
114
116
-
All test files are in `[test/test.js](https://github.com/sendgrid/nodejs-http-client/blob/master/test/test.js)`.
115
+
All test files are in [`test/test.js`](https://github.com/sendgrid/nodejs-http-client/blob/master/test/test.js).
117
116
118
117
For the purposes of contributing to this repo, please update the [`test.js`](https://github.com/sendgrid/nodejs-http-client/blob/master/test/test.js) file with unit tests as you modify the code.
119
118
@@ -126,15 +125,11 @@ Run the test:
126
125
127
126
Generally, we follow the style guidelines as suggested by the official language. However, we ask that you conform to the styles that already exist in the library. If you wish to deviate, please explain your reasoning.
Following is an abridged example, here is the [full working code](https://github.com/sendgrid/nodejs-http-client/blob/master/examples/example.js).
74
+
Here is the [full working code](https://github.com/sendgrid/nodejs-http-client/blob/master/examples/example.js).
75
+
76
+
To run the example:
69
77
70
78
```bash
71
79
node examples/example
72
80
```
73
81
74
-
```javascript
75
-
var Client =require('sendgrid-rest').Client
76
-
var emptyRequest =require('sendgrid-rest').request
77
-
78
-
// These values persist across of subsequent calls, unless overidden.
79
-
var globalRequest =JSON.parse(JSON.stringify(emptyRequest))
If you are intersted in the future direction of this project, please take a look at our [milestones](https://github.com/sendgrid/nodejs-http-client/milestones). We would love to hear your feedback.
169
85
170
-
# How to Contribute
86
+
##How to Contribute
171
87
172
88
We encourage contribution to our libraries, please see our [CONTRIBUTING](https://github.com/sendgrid/nodejs-http-client/blob/master/CONTRIBUTING.md) guide for details.
173
89
@@ -177,9 +93,9 @@ We encourage contribution to our libraries, please see our [CONTRIBUTING](https:
0 commit comments