Skip to content

The code is too concrete #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ch-hristov opened this issue Apr 13, 2017 · 2 comments
Closed

The code is too concrete #435

ch-hristov opened this issue Apr 13, 2017 · 2 comments
Labels
status: duplicate duplicate issue

Comments

@ch-hristov
Copy link

Issue Summary

Please extract the important object information into interfaces cause otherwise I'm forced to use your implementations and cannot provide my own in an easy way.

@thinkingserious thinkingserious added the status: duplicate duplicate issue label Apr 13, 2017
@thinkingserious
Copy link
Contributor

Thanks @ch-hristov,

I've added your vote to this issue: #403

@Jericho
Copy link

Jericho commented Apr 16, 2017

@ch-hristov: I posted a comment on issue 403 which I thought you might find useful: I suggested considering StrongGrid which is an alternative .net client implementing an interface for easy mocking. (disclaimer: I'm the author of this library)

It also allows you to inject a httClient so that, if you prefer, you can mock the data returned from the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate duplicate issue
Projects
None yet
Development

No branches or pull requests

3 participants