Skip to content

Java interface for SendGrid class #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrylis opened this issue May 2, 2017 · 2 comments
Closed

Java interface for SendGrid class #194

chrylis opened this issue May 2, 2017 · 2 comments
Labels
status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap

Comments

@chrylis
Copy link

chrylis commented May 2, 2017

As of 3.2.1, all of the SendGrid functionality is implemented directly in the SendGrid class, which is directly descended from Object and implements no interfaces. This makes mocking out SendGrid calls for testing difficult--especially the message-driven integration test "this API call actually does cause mail to be sent!" It would be preferable to have a SendGridApi or similar interface that covered at least the core methods.

I'll tag #140 here because of the theme, but this refactoring can be done without breaking anything--adding a new interface implementation won't cause problems.

@thinkingserious thinkingserious added status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap labels May 3, 2017
@thinkingserious
Copy link
Contributor

Thanks @chrylis,

I have added this to our backlog.

In the mean time, you can use the Prism mock server like so.

With Best Regards,

Elmer

@thinkingserious
Copy link
Contributor

This should be implemented here

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 1, 2017
@mbernier mbernier removed difficulty: very hard fix is very hard in difficulty difficulty: medium fix is medium in difficulty labels Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

3 participants