Skip to content

Prevent secrets from sending in email #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thinkingserious opened this issue Oct 16, 2017 · 2 comments · Fixed by #502
Closed

Prevent secrets from sending in email #496

thinkingserious opened this issue Oct 16, 2017 · 2 comments · Fixed by #502
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 16, 2017 •
edited
Loading

Add a method that will check the content of the email before sending, to make sure that specific strings or patterns are not included.

For example, SG API keys look like this: SG.[a-zA-Z0-9_].[a-zA-Z0-9-].

So the function could take a list of regex or specific strings to compare against. If a string is found, the mail/send should throw an exception
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 16, 2017
@spelcaster spelcaster mentioned this issue Oct 17, 2017
Merged
@spelcaster
Copy link
Contributor

Follow #502

@thinkingserious thinkingserious added the status: work in progress Twilio or the community is in the process of implementing label Oct 17, 2017
@thinkingserious
Copy link
Contributor Author

Thanks @spelcaster!

@mbernier mbernier removed difficulty: easy fix is easy in difficulty difficulty: hard fix is hard in difficulty difficulty: medium fix is medium in difficulty labels Oct 27, 2017
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent secrets from sending in email spelcaster/sendgrid-nodejs
3 participants
@thinkingserious @mbernier @spelcaster