Skip to content

Make SerilogLogger type public #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
victorhurdugaci opened this issue Jul 29, 2016 · 3 comments
Closed

Make SerilogLogger type public #45

victorhurdugaci opened this issue Jul 29, 2016 · 3 comments
Assignees

Comments

@victorhurdugaci
Copy link

Since the only public type in this package is the extension methods of the logger factory, if you want to create a logger instance, you always have to go through the factory.

For the WebApps logger, we just need an instance of the serilog logger, but that forces us to create an factory before we can create the logger. It would be useful to have that type public so we can instantiate it directly.

@nblumhardt
Copy link
Member

Thanks for the feedback Victor, sounds fine. I can make this change in the next day or two, or happy to accept a PR if you can send one.

@merbla
Copy link
Contributor

merbla commented Jul 29, 2016

@nblumhardt we will have to open up SerilogLoggerProvider & SerilogLoggerScope in addition to SerilogLogger.

Not sure if that is the intent.

@nblumhardt
Copy link
Member

Released in 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants