default webpackConfig.node should be false #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
completely turn off the NodeStuffPlugin and NodeSourcePlugin plugins. We don't want webpack to mock node globals See https://codeburst.io/use-webpack-with-dirname-correctly-4cad3b265a92 and https://webpack.js.org/configuration/node
|
Good catch 👍 . Could you please add the check for the default value to the unit tests to keep up the coverage and complete the checklist above (TODOS)? |
HyperBrain
approved these changes
Jun 2, 2019
|
I'm waiting with the merge, because a fix for #505 might still go into 5.3.1 as it is urgent but this one is for 5.4.0 as it is a feature by nature, not a bug fix that does not change the expectations. |
hassankhan
approved these changes
Jun 2, 2019
miguel-a-calles-mba
approved these changes
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
completely turn off the NodeStuffPlugin and NodeSourcePlugin plugins.
We don't want webpack to mock node globals
See https://codeburst.io/use-webpack-with-dirname-correctly-4cad3b265a92 and https://webpack.js.org/configuration/node
What did you implement:
Closes #XXXXX
How did you implement it:
How can we verify it:
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO