Skip to content

Overriding the servicePath breaks other plugins #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SanderKnape opened this issue Oct 10, 2021 · 4 comments
Open

Overriding the servicePath breaks other plugins #253

SanderKnape opened this issue Oct 10, 2021 · 4 comments

Comments

@SanderKnape
Copy link

Hello. This package overrides the servicePath, causing issues for other plugins that are now trying to find files (such as the schema.graphql) in the .build folder instead of the root.

I ran into this issue with the serverless-appsync-simulator, and I see it also causes issues when using Lambda layers.

Is there any chance this functionality can be changed to improve compatibility with other plugins?

@avafloww
Copy link

This also breaks serverless-azure-functions.

@alexandrubese
Copy link

Is there any timeframe for fixing this?
Its an open dependency for working with lambda layers which is a common used pattern :
#240

Without this fix this plugin is rendered useless in working with layers without including other plugins such as serverless-jetpack

@liam-ot
Copy link

liam-ot commented Feb 9, 2023

hello, i have a possible solution for this can someone give me the rights to open a PR please?

also, a workaround here is to include your graphql schema location in the pacakge.patterns array like so:

app: foobar
…
package:
  excludeDevDependencies: true
  patterns:
    - '!node_modules/aws-sdk'
    - '!node_modules/**/aws-sdk/**'
    - '!.vscode/**'
    - '!.dynamodb/**'
    - 'schema.graphql'
…

@liam-ot
Copy link

liam-ot commented Feb 9, 2023

@medikoo tagging you to point you to my comment above :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants