Skip to content

The size of CGDisplay #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #719
daniel-abramov opened this issue May 18, 2018 · 1 comment
Open
Tracked by #719

The size of CGDisplay #218

daniel-abramov opened this issue May 18, 2018 · 1 comment

Comments

@daniel-abramov
Copy link
Contributor

I've just checked the values which CGDisplay::pixels_high() and CGDisplay::pixels_wide() return (I wrote a simple test that calls CGDisplay::main() and then prints some properties of it. It seems that the returned values are not in pixels, but in points. I know that CGDisplay wrapper uses the correct functions CGDisplayPixelsHigh() and CGDisplayPixelsWide(), but apparently they don't return the size in pixels. Should we rename the functions in CGDisplay, so that the documentation and function names better reflect the actual way they work?

@jrmuizel
Copy link
Collaborator

I'm inclined to just leave the name matching the upstream name. It might be worth adding some documentation about this though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants