Skip to content

Fresh pre-commit is failing on the master #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ravwojdyla opened this issue Sep 23, 2020 · 3 comments · Fixed by #274
Closed

Fresh pre-commit is failing on the master #275

ravwojdyla opened this issue Sep 23, 2020 · 3 comments · Fixed by #274
Assignees
Labels
bug Something isn't working process + tools

Comments

@ravwojdyla
Copy link
Collaborator

Needed to create a fresh conda env for sgkit dev, and fresh pre-commit env is failing on master with:

mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

sgkit/stats/utils.py:46: error: unused 'type: ignore' comment
sgkit/display.py:182: error: unused 'type: ignore' comment
sgkit/tests/test_association.py:135: error: unused 'type: ignore' comment
sgkit/tests/test_association.py:186: error: unused 'type: ignore' comment
sgkit/tests/test_association.py:188: error: unused 'type: ignore' comment
sgkit/tests/test_hwe.py:140: error: unused 'type: ignore' comment
sgkit/tests/test_regenie.py:190: error: unused 'type: ignore' comment
Found 7 errors in 5 files (checked 44 source files)

This doesn't seem to fail on GH, presumably because pre-commit is still using cache for its envs.

@eric-czech
Copy link
Collaborator

Hmm any idea why are these failing now if the mypy version hasn't ever been changed?

@ravwojdyla
Copy link
Collaborator Author

ravwojdyla commented Sep 23, 2020

@eric-czech yea, the reason why this is failing on a new pre-commit env:

  • xarray 0.16.1 was released 3 days ago
  • pre-commit GH actions comes with cache built-in
  • since pre-commit config files have not changed in last 3 days, cache has not been invalidated yet, and our master is still testing against xarray 0.16.0

Does this make sense?

@eric-czech
Copy link
Collaborator

Oo I see, so Xarray add some type hints. Ty.

@ravwojdyla ravwojdyla linked a pull request Sep 23, 2020 that will close this issue
@mergify mergify bot closed this as completed in #274 Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working process + tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants