Skip to content

Remove xarray_internal concat algorithm in VCF reader #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomwhite opened this issue Sep 16, 2021 · 3 comments · Fixed by #741
Closed

Remove xarray_internal concat algorithm in VCF reader #678

tomwhite opened this issue Sep 16, 2021 · 3 comments · Fixed by #741
Labels
upstream Used when our build breaks due to upstream changes
Milestone

Comments

@tomwhite
Copy link
Collaborator

As discussed in #665, concat_algorithm="xarray_internal" has scaling issues, and doesn't handle variable-length strings well, so we can drop it to simplify the code.

@hammer
Copy link
Contributor

hammer commented Sep 16, 2021

@tomwhite could you link to the upstream issue for the scaling issues here? 🙏

@tomwhite
Copy link
Collaborator Author

The Dask issue is dask/dask#6745. It's now closed, although the problem hasn't been fixed.

@tomwhite
Copy link
Collaborator Author

I should add that fixing this would avoid another problem we have been having with Xarray: pydata/xarray#5769

@tomwhite tomwhite added this to the 0.4.0 milestone Oct 5, 2021
@hammer hammer added the upstream Used when our build breaks due to upstream changes label Oct 18, 2021
@mergify mergify bot closed this as completed in #741 Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Used when our build breaks due to upstream changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants