Skip to content

Remove support for Python 3.7 #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tomwhite opened this issue Jan 17, 2022 · 6 comments · Fixed by #927
Closed

Remove support for Python 3.7 #802

tomwhite opened this issue Jan 17, 2022 · 6 comments · Fixed by #927
Labels
process + tools upstream Used when our build breaks due to upstream changes

Comments

@tomwhite
Copy link
Collaborator

NumPy 1.22 no longer supports Python 3.7, so we should consider removing support for it in the next release of sgkit.

This would be consistent with https://numpy.org/neps/nep-0029-deprecation_policy.html, which says Python 3.7 can be dropped from Dec 26, 2021.
@jeromekelleher
Copy link
Collaborator

Seems quite early to drop 3.7 tbh - is there much to be gained? To me there aren't any standout features in 3.8 making it worthwhile, and we're unlikely to (shouldn't?) depend on features required numpy 1.22 for a long time.

I don't feel strongly about it, though.

@tomwhite
Copy link
Collaborator Author

No particular rush, just wanted to open it for discussion. Installing Python 3.8 envs using conda is easy enough on most platforms so I suspect that shouldn't be a blocker.

@tomwhite
Copy link
Collaborator Author

Well that was quick. Our upstream tests just failed because xarray has already dropped Python 3.7.

@tomwhite tomwhite mentioned this issue Jan 17, 2022
Merged
@hammer hammer added the upstream Used when our build breaks due to upstream changes label Jan 17, 2022
@tomwhite
Copy link
Collaborator Author

tomwhite commented Feb 2, 2022

Pandas 1.4.0 does not support Python 3.7.

@tomwhite tomwhite mentioned this issue Sep 29, 2022
Merged
@tomwhite
Copy link
Collaborator Author

tomwhite commented Oct 5, 2022

The build is now failing on Python 3.7 (https://github.com/pystatgen/sgkit/actions/runs/3186604485), so I'm thinking it's probably time to remove support for it.

@jeromekelleher
Copy link
Collaborator

No point in swimming against the tide I guess.

@tomwhite tomwhite mentioned this issue Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
process + tools upstream Used when our build breaks due to upstream changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove python 3.7 tomwhite/sgkit
3 participants
@hammer @tomwhite @jeromekelleher