dart-lang#1399. [Records] Record expressions tests updated according to the specification changes

Author: sgrekhov

LanguageFeatures/Records/record_expressions_A01_t01.dart

@@ -15,13 +15,16 @@
 ///
 /// The same field name more than once.
 ///
-/// No named fields and only one positional field. This avoids ambiguity with
-/// parenthesized expressions.
+/// Only one positional field and no trailing comma.
 ///
 /// A field named hashCode, runtimeType, noSuchMethod, or toString.
 ///
 /// A field name that starts with an underscore.
 ///
+/// A field name that collides with the synthesized getter name of a positional
+/// field. For example: ('pos', $0: 'named') since the named field '$0' collides
+/// with the getter for the first positional field.
+///
 /// @description Checks that it is a compile-time error if a record has the same
 /// field name more than once
 /// @author [email protected]

LanguageFeatures/Records/record_expressions_A01_t02.dart

@@ -15,13 +15,16 @@
 ///
 /// The same field name more than once.
 ///
-/// No named fields and only one positional field. This avoids ambiguity with
-/// parenthesized expressions.
+/// Only one positional field and no trailing comma.
 ///
 /// A field named hashCode, runtimeType, noSuchMethod, or toString.
 ///
 /// A field name that starts with an underscore.
 ///
+/// A field name that collides with the synthesized getter name of a positional
+/// field. For example: ('pos', $0: 'named') since the named field '$0' collides
+/// with the getter for the first positional field.
+///
 /// @description Checks that it is a compile-time error if a record has the same
 /// field name more than once
 /// @author [email protected]

LanguageFeatures/Records/record_expressions_A02_t01.dart

@@ -15,15 +15,18 @@
 ///
 /// The same field name more than once.
 ///
-/// No named fields and only one positional field. This avoids ambiguity with
-/// parenthesized expressions.
+/// Only one positional field and no trailing comma.
 ///
 /// A field named hashCode, runtimeType, noSuchMethod, or toString.
 ///
 /// A field name that starts with an underscore.
 ///
+/// A field name that collides with the synthesized getter name of a positional
+/// field. For example: ('pos', $0: 'named') since the named field '$0' collides
+/// with the getter for the first positional field.
+///
 /// @description Checks that it is a compile-time error if a record has no named
-/// fields and only one positional field
+/// fields and only one positional field with no trailing comma
 /// @author [email protected]
 
 // SharedOptions=--enable-experiment=records

LanguageFeatures/Records/record_expressions_A02_t02.dart

@@ -15,15 +15,18 @@
 ///
 /// The same field name more than once.
 ///
-/// No named fields and only one positional field. This avoids ambiguity with
-/// parenthesized expressions.
+/// Only one positional field and no trailing comma.
 ///
 /// A field named hashCode, runtimeType, noSuchMethod, or toString.
 ///
 /// A field name that starts with an underscore.
 ///
+/// A field name that collides with the synthesized getter name of a positional
+/// field. For example: ('pos', $0: 'named') since the named field '$0' collides
+/// with the getter for the first positional field.
+///
 /// @description Checks that it is a compile-time error if a record has no named
-/// fields and only one positional field
+/// fields and only one positional field with no trailing comma
 /// @author [email protected]
 
 // SharedOptions=--enable-experiment=records

LanguageFeatures/Records/record_expressions_A02_t03.dart

@@ -0,0 +1,44 @@
+// Copyright (c) 2022, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+/// @assertion A record is created using a record expression. The grammar is:
+///
+/// literal      ::= record
+///                | // Existing literal productions...
+/// record       ::= '(' recordField ( ',' recordField )* ','? ')'
+/// recordField  ::= (identifier ':' )? expression
+///
+/// This is identical to the grammar for a function call argument list. There
+/// are a couple of syntactic restrictions not captured by the grammar. It is a
+/// compile-time error if a record has any of:
+///
+/// The same field name more than once.
+///
+/// Only one positional field and no trailing comma.
+///
+/// A field named hashCode, runtimeType, noSuchMethod, or toString.
+///
+/// A field name that starts with an underscore.
+///
+/// A field name that collides with the synthesized getter name of a positional
+/// field. For example: ('pos', $0: 'named') since the named field '$0' collides
+/// with the getter for the first positional field.
+///
+/// @description Checks that it is no error if a record has no named fields and
+/// only one positional field but with a trailing comma
+/// @author [email protected]
+
+// SharedOptions=--enable-experiment=records
+
+import "../../Utils/expect.dart";
+
+main() {
+  var r1 = (1,);
+  var r2 = ((2),);
+  var r3 = ((3,),);
+
+  Expect.equals(1, r1.$0);
+  Expect.equals(2, r2.$0);
+  Expect.equals(3, r2.$0.$0);
+}

LanguageFeatures/Records/record_expressions_A02_t04.dart

@@ -0,0 +1,50 @@
+// Copyright (c) 2022, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+/// @assertion A record is created using a record expression. The grammar is:
+///
+/// literal      ::= record
+///                | // Existing literal productions...
+/// record       ::= '(' recordField ( ',' recordField )* ','? ')'
+/// recordField  ::= (identifier ':' )? expression
+///
+/// This is identical to the grammar for a function call argument list. There
+/// are a couple of syntactic restrictions not captured by the grammar. It is a
+/// compile-time error if a record has any of:
+///
+/// The same field name more than once.
+///
+/// Only one positional field and no trailing comma.
+///
+/// A field named hashCode, runtimeType, noSuchMethod, or toString.
+///
+/// A field name that starts with an underscore.
+///
+/// A field name that collides with the synthesized getter name of a positional
+/// field. For example: ('pos', $0: 'named') since the named field '$0' collides
+/// with the getter for the first positional field.
+///
+/// @description Checks that it is no error if a record has no named fields and
+/// only one positional field but with a trailing comma
+/// @author [email protected]
+
+// SharedOptions=--enable-experiment=records
+
+import "../../Utils/expect.dart";
+
+Record foo1() => (1,);
+
+Record foo2() => ((2),);
+
+Record foo3() => ((3,),);
+
+dynamic bar(Record r) => r
+
+main() {
+  Expect.equals(1, foo1());
+  Expect.equals(2, foo2());
+  Expect.equals((3,), foo3());
+  Expect.equals(("Hello",), bar(("Hello",)));
+  Expect.equals(("Hello",), bar((("Hello"),)));
+}

LanguageFeatures/Records/record_expressions_A03_t01.dart

@@ -15,13 +15,16 @@
 ///
 /// The same field name more than once.
 ///
-/// No named fields and only one positional field. This avoids ambiguity with
-/// parenthesized expressions.
+/// Only one positional field and no trailing comma.
 ///
 /// A field named hashCode, runtimeType, noSuchMethod, or toString.
 ///
 /// A field name that starts with an underscore.
 ///
+/// A field name that collides with the synthesized getter name of a positional
+/// field. For example: ('pos', $0: 'named') since the named field '$0' collides
+/// with the getter for the first positional field.
+///
 /// @description Checks that it is a compile-time error if a record has a field
 /// named `hashCode`, `runtimeType`, `noSuchMethod`, or `toString`
 /// @author [email protected]

LanguageFeatures/Records/record_expressions_A03_t02.dart

@@ -15,13 +15,16 @@
 ///
 /// The same field name more than once.
 ///
-/// No named fields and only one positional field. This avoids ambiguity with
-/// parenthesized expressions.
+/// Only one positional field and no trailing comma.
 ///
 /// A field named hashCode, runtimeType, noSuchMethod, or toString.
 ///
 /// A field name that starts with an underscore.
 ///
+/// A field name that collides with the synthesized getter name of a positional
+/// field. For example: ('pos', $0: 'named') since the named field '$0' collides
+/// with the getter for the first positional field.
+///
 /// @description Checks that it is a compile-time error if a record has a field
 /// named `hashCode`, `runtimeType`, `noSuchMethod`, or `toString`
 /// @author [email protected]

LanguageFeatures/Records/record_expressions_A04_t01.dart

@@ -15,13 +15,16 @@
 ///
 /// The same field name more than once.
 ///
-/// No named fields and only one positional field. This avoids ambiguity with
-/// parenthesized expressions.
+/// Only one positional field and no trailing comma.
 ///
 /// A field named hashCode, runtimeType, noSuchMethod, or toString.
 ///
 /// A field name that starts with an underscore.
 ///
+/// A field name that collides with the synthesized getter name of a positional
+/// field. For example: ('pos', $0: 'named') since the named field '$0' collides
+/// with the getter for the first positional field.
+///
 /// @description Checks that it is a compile-time error if a record has a field
 /// name that starts with an underscore
 /// @author [email protected]

LanguageFeatures/Records/record_expressions_A05_t01.dart

@@ -0,0 +1,56 @@
+// Copyright (c) 2022, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+/// @assertion A record is created using a record expression. The grammar is:
+///
+/// literal      ::= record
+///                | // Existing literal productions...
+/// record       ::= '(' recordField ( ',' recordField )* ','? ')'
+/// recordField  ::= (identifier ':' )? expression
+///
+/// This is identical to the grammar for a function call argument list. There
+/// are a couple of syntactic restrictions not captured by the grammar. It is a
+/// compile-time error if a record has any of:
+///
+/// The same field name more than once.
+///
+/// Only one positional field and no trailing comma.
+///
+/// A field named hashCode, runtimeType, noSuchMethod, or toString.
+///
+/// A field name that starts with an underscore.
+///
+/// A field name that collides with the synthesized getter name of a positional
+/// field. For example: ('pos', $0: 'named') since the named field '$0' collides
+/// with the getter for the first positional field.
+///
+/// @description Checks that it is a compile-time error if a record has a field
+/// name that collides with the synthesized getter name of a positional field
+/// @author [email protected]
+
+// SharedOptions=--enable-experiment=records
+
+Record foo() => (42, $0: "Lily was here");
+//                   ^^
+// [analyzer] unspecified
+// [cfe] unspecified
+
+void bar(Record r) {}
+
+main() {
+  var record1 = (42, $0: "Lily was here");
+//                   ^^
+// [analyzer] unspecified
+// [cfe] unspecified
+
+  var record2 = (1, 2, 3, $2: 42);
+//                        ^^
+// [analyzer] unspecified
+// [cfe] unspecified
+
+  bar((42, $0: 42));
+//         ^^
+// [analyzer] unspecified
+// [cfe] unspecified
+}

LanguageFeatures/Records/record_expressions_A06_t01.dart

@@ -0,0 +1,31 @@
+// Copyright (c) 2022, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+/// @assertion There is no syntax for a zero-field record expression. Instead,
+/// there is a static constant empty on [Record] that returns the empty record.
+///
+/// @description Checks that there is no syntax for a zero-field record
+/// expression.
+/// @author [email protected]
+
+// SharedOptions=--enable-experiment=records
+
+Record foo() => ();
+//              ^^
+// [analyzer] unspecified
+// [cfe] unspecified
+
+void bar(Record r) {}
+
+main() {
+  var record1 = ();
+//              ^^
+// [analyzer] unspecified
+// [cfe] unspecified
+
+  bar(());
+//    ^^
+// [analyzer] unspecified
+// [cfe] unspecified
+}

LanguageFeatures/Records/record_expressions_A06_t02.dart

@@ -0,0 +1,24 @@
+// Copyright (c) 2022, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+/// @assertion There is no syntax for a zero-field record expression. Instead,
+/// there is a static constant empty on [Record] that returns the empty record.
+///
+/// @description Checks that there is a static constant empty on [Record] that
+/// returns the empty record
+/// @author [email protected]
+
+// SharedOptions=--enable-experiment=records
+
+import "../../Utils/expect.dart";
+
+Record foo() => Record.empty;
+
+Record bar(Record r) => r;
+
+main() {
+  var record1 = Record.empty;
+  Expect.equals(Record.empty, record1);
+  Expect.equals(Record.empty, bar(Record.empty));
+}