Skip to content

Babel polyfills missing #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christemple opened this issue Jan 5, 2016 · 7 comments
Closed

Babel polyfills missing #13

christemple opened this issue Jan 5, 2016 · 7 comments

Comments

@christemple
Copy link

Hi guys,

I just tried cloning and trying out the examples and run into an issue.

It seems that areas of your code are using ES6 features that require babels polyfills which are not included, for example the Array.prototype.find method, examples of which are used here:

https://github.com/shakacode/bootstrap-loader/blob/master/src/utils/processStyleLoaders.js#L28-L31

If I add the babel polyfills as a precursor to using bootstrap-loader in my webpack config file it works.

Is this something you guys have seen before?

Thanks,
Chris Temple

@justin808
Copy link
Member

@alexfedoseev We might have missed the babel runtime?

@alex35mil
Copy link
Member

@justin808 Yep, we should do it. I guess it's an issue for Node <=0.12 users.
@christemple What's your node version?

@christemple
Copy link
Author

@alexfedoseev yep you guessed it, my node version is v0.12.0

@alex35mil
Copy link
Member

@christemple @justin808 I investigated this issue and I added babel-polyfill instead of babel-runtime b/c of this.

1.0.3 is published. @christemple Can you try it out and close the issue if it works?

/cc: @AllenFang

@christemple
Copy link
Author

Updated to 1.0.3 and removed my own babel-polyfill dependency and can confirm it's working 👍

Thanks guys

@bopeng87
Copy link

bopeng87 commented Mar 4, 2016

the problem comes back on 1.0.6 and 1.0.9 :(

@bopeng87
Copy link

bopeng87 commented Mar 4, 2016

I have to go back to 1.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants