Add back animations disabling

Author: justin808

spec/features/shared/examples.rb

@@ -43,14 +43,10 @@
 shared_examples "Validation errors displaying" do
   context "when the new comment is submitted with blank fields", blank_form_submitted: true do
     scenario "validation errors displayed" do
-      puts "ZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZ"
-      puts "examples.rb: #{__LINE__},  method: #{__method__}"
-      # puts "triggering sleep 1"
-      puts "zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz"
-      # # sleep 1
-      # # puts "zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz"
-      # puts "After sleep 1"
-      # puts "ZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZ"
+      # Sleeping is CRITICAL to this test not crashing on Travis
+      # See builds here:
+      # https://travis-ci.org/shakacode/react-webpack-rails-tutorial/builds/178794772
+      # sleep 1
 
       expect(page).to have_content("Your comment was not saved!")
       expect(page).to have_content("Author: can't be blank")

spec/rails_helper.rb

@@ -41,7 +41,8 @@
   # Maybe selenium_firefox webdriver only works for Travis-CI builds.
   # 2016-03-06: Phantomjs, all options fails on MacOs
   # Same for webkit
-  default_driver = :poltergeist # :selenium_chrome
+  # default_driver = :poltergeist
+  default_driver = :poltergeist_no_animations # :selenium_chrome
 
   supported_drivers = %i( poltergeist poltergeist_errors_ok
                           poltergeist_no_animations webkit
@@ -56,6 +57,7 @@
   when :poltergeist, :poltergeist_errors_ok, :poltergeist_no_animations
     require "capybara/poltergeist"
     opts = {
+      # Leaving animations off, as a sleep was still needed.
       extensions: ["#{Rails.root}/spec/support/phantomjs-disable-animations.js"],
       window_size: [1280, 720],
       screen_size: [1600, 1200]

spec/support/phantomjs-disable-animations.js

@@ -1,5 +1,9 @@
 // https://gist.github.com/andyjbas/9962218
 // disable_animations.js
+
+// No idea which of these is more helpful.
+// They both resulted in crashes:
+// https://travis-ci.org/shakacode/react-webpack-rails-tutorial/builds/178794772
 // var disableAnimationStyles = '-webkit-transition: none !important;' +
 //                              '-moz-transition: none !important;' +
 //                              '-ms-transition: none !important;' +