Ignoring Procfiles for rubocop. Auto-fixing rubocop warnings

Author: tmobaird

.rubocop.yml

@@ -7,6 +7,7 @@ AllCops:
   Include:
     - '**/Rakefile'
     - '**/config.ru'
+    - '**/Gemfile'
   Exclude:
     - 'vendor/**/*'
     - 'spec/fixtures/**/*'
@@ -16,6 +17,7 @@ AllCops:
     - 'db/seeds.rb'
     - 'client/node_modules/**/*'
     - 'bin/**/*'
+    - 'Procfile.*'
     - !ruby/regexp /old_and_unused\.rb$/
 
 Metrics/LineLength:

Gemfile

@@ -3,8 +3,8 @@ ruby "2.4.1"
 
 #
 # Bundle edge Rails instead: gem "rails", github: "rails/rails"
-gem "rails"
 gem "listen"
+gem "rails"
 
 # Note: We're using sqllite3 for development and testing
 # gem "sqlite3", group: [:development, :test]
@@ -27,7 +27,7 @@ gem "coffee-rails"
 
 # Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder
 gem "jbuilder"
-gem 'redis'
+gem "redis"
 
 # bundle exec rake doc:rails generates the API under doc/api.
 gem "sdoc", group: :doc
@@ -65,38 +65,38 @@ group :development, :test do
 
   ################################################################################
   # Manage application processes
-  gem "foreman"
   gem "factory_girl_rails"
+  gem "foreman"
 
   ################################################################################
   # Linters and Security
   gem "rubocop", require: false
   gem "ruby-lint", require: false
   # Critical that require: false be set! https://github.com/brigade/scss-lint/issues/278
-  gem "scss_lint", require: false
   gem "brakeman", require: false
   gem "bundler-audit", require: false
+  gem "scss_lint", require: false
 
   ################################################################################
   # Favorite debugging gems
   gem "pry"
+  gem "pry-byebug"
   gem "pry-doc"
   gem "pry-rails"
-  gem "pry-stack_explorer"
   gem "pry-rescue"
-  gem "pry-byebug"
+  gem "pry-stack_explorer"
 
   ################################################################################
   # Color console output
   gem "rainbow"
 end
 
-group :test  do
-  gem "coveralls", require: false
+group :test do
   gem "capybara"
   gem "capybara-screenshot"
   gem "capybara-webkit"
   gem "chromedriver-helper"
+  gem "coveralls", require: false
   gem "database_cleaner"
   gem "generator_spec"
   gem "launchy"

app/controllers/comments_controller.rb

@@ -1,5 +1,5 @@
 class CommentsController < ApplicationController
-  before_action :set_comment, only: [:show, :edit, :update, :destroy]
+  before_action :set_comment, only: %i[show edit update destroy]
 
   # GET /comments
   # GET /comments.json
@@ -9,17 +9,15 @@ def index
 
   # GET /comments/1
   # GET /comments/1.json
-  def show
-  end
+  def show; end
 
   # GET /comments/new
   def new
     @comment = Comment.new
   end
 
   # GET /comments/1/edit
-  def edit
-  end
+  def edit; end
 
   # POST /comments
   # POST /comments.json

app/controllers/pages_controller.rb

@@ -32,8 +32,7 @@ def no_router
     render_html
   end
 
-  def simple
-  end
+  def simple; end
 
   private
 

app/views/comments/show.json.jbuilder

@@ -1 +1 @@
-json.partial! 'comment', comment: @comment
+json.partial! "comment", comment: @comment

config/initializers/react_on_rails.rb

@@ -2,11 +2,11 @@
 ReactOnRails.configure do |config|
   # Directory where your generated assets go. All generated assets must go to the same directory.
   # Configure this in your webpack config files. This relative to your Rails root directory.
-  config.generated_assets_dir = File.join(%w(app assets webpack))
+  config.generated_assets_dir = File.join(%w[app assets webpack])
 
   # Define the files for we need to check for webpack compilation when running tests
-  config.webpack_generated_files = %w( app-bundle.js vendor-bundle.js app-bundle.css
-                                       vendor-bundle.css server-bundle.js )
+  config.webpack_generated_files = %w[ app-bundle.js vendor-bundle.js app-bundle.css
+                                       vendor-bundle.css server-bundle.js ]
 
   # This is the file used for server rendering of React when using `(prerender: true)`
   # If you are never using server rendering, you may set this to "".

lib/tasks/brakeman.rake

@@ -1,17 +1,16 @@
 namespace :brakeman do
-
   desc "Run Brakeman"
-  task :run, :output_files do |t, args|
-    require 'brakeman'
+  task :run, :output_files do |_t, args|
+    require "brakeman"
 
-    files = args[:output_files].split(' ') if args[:output_files]
-    Brakeman.run :app_path => ".", :output_files => files, :print_report => true
+    files = args[:output_files].split(" ") if args[:output_files]
+    Brakeman.run app_path: ".", output_files: files, print_report: true
   end
 
   desc "Check your code with Brakeman"
   task :check do
-    require 'brakeman'
-    result = Brakeman.run app_path: '.', print_report: true
+    require "brakeman"
+    result = Brakeman.run app_path: ".", print_report: true
     exit Brakeman::Warnings_Found_Exit_Code unless result.filtered_warnings.empty?
   end
 end

lib/tasks/ci.rake

@@ -25,13 +25,13 @@ if Rails.env.development? || Rails.env.test?
   namespace :ci do
     desc "Run all audits and tests"
     # rspec_tests must be before lint and js_tests to build the locale files
-    task all: [:environment, :rspec_tests, :lint, :js_tests, :bundle_audit, :security_audit] do
+    task all: %i[environment rspec_tests lint js_tests bundle_audit security_audit] do
       begin
         puts "All CI tasks"
         puts Rainbow("PASSED").green
         puts ""
       rescue Exception => e
-        puts "#{e}"
+        puts e.to_s
         puts Rainbow("FAILED").red
         puts ""
         raise(e)

lib/tasks/linters.rake

@@ -1,4 +1,4 @@
-if %w(development test).include? Rails.env
+if %w[development test].include? Rails.env
   namespace :lint do
     # require "rubocop/rake_task"
     # require "slim_lint/rake_task"
@@ -10,9 +10,9 @@ if %w(development test).include? Rails.env
     desc "Run Rubocop lint as shell. Specify option fix to auto-correct (and don't have uncommitted files!)."
     task :rubocop, [:fix] => [] do |_t, args|
       def to_bool(str)
-        return true if str =~ (/^(true|t|yes|y|1)$/i)
-        return false if str.blank? || str =~ (/^(false|f|no|n|0)$/i)
-        fail ArgumentError, "invalid value for Boolean: \"#{str}\""
+        return true if str =~ /^(true|t|yes|y|1)$/i
+        return false if str.blank? || str =~ /^(false|f|no|n|0)$/i
+        raise ArgumentError, "invalid value for Boolean: \"#{str}\""
       end
 
       fix = (args.fix == "fix") || to_bool(args.fix)
@@ -54,7 +54,7 @@ if %w(development test).include? Rails.env
     desc "See docs for task 'scss_lint'"
     task scss: :scss_lint
 
-    task lint: [:rubocop, :ruby, :js, :scss] do
+    task lint: %i[rubocop ruby js scss] do
       puts "Completed all linting"
     end
   end

spec/rails_helper.rb

@@ -55,9 +55,9 @@
 
   default_driver = :poltergeist_no_animations
 
-  supported_drivers = %i( poltergeist poltergeist_errors_ok
+  supported_drivers = %i[ poltergeist poltergeist_errors_ok
                           poltergeist_no_animations webkit
-                          selenium_chrome selenium_firefox selenium)
+                          selenium_chrome selenium_firefox selenium]
   driver = ENV["DRIVER"].try(:to_sym) || default_driver
   Capybara.default_driver = driver
 

spec/support/poltergeist.rb

@@ -3,7 +3,7 @@
 # 2. restart_poltergeist
 
 RESTART_PHANTOMJS = ENV["RESTART_PHANTOMJS"] &&
-                    %w(TRUE YES).include?(ENV["RESTART_PHANTOMJS"].upcase)
+                    %w[TRUE YES].include?(ENV["RESTART_PHANTOMJS"].upcase)
 puts "RESTART_PHANTOMJS = #{RESTART_PHANTOMJS}"
 
 CAPYBARA_TIMEOUT_RETRIES = 5