Skip to content

Commit 3042682

Browse files
committed
Merge pull request #223 from shakacode/revert-222-feature/add-cross-component-store
Revert "upgraded to version 3 of react on rails"
2 parents a02f475 + 67df994 commit 3042682

13 files changed

+387
-402
lines changed

.ruby-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.2.4
1+
2.2.3

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
language:
22
- ruby
33
rvm:
4-
- 2.2.4
4+
- 2.2.3
55
sudo: false
66
addons:
77
apt:

Gemfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
source "https://rubygems.org"
2-
ruby "2.2.4"
2+
ruby "2.2.3"
33

44
#
55
# Bundle edge Rails instead: gem "rails", github: "rails/rails"
@@ -37,7 +37,7 @@ gem "sdoc", group: :doc
3737
# Use Rails Html Sanitizer for HTML sanitization
3838
gem "rails-html-sanitizer"
3939

40-
gem "react_on_rails", git: "[email protected]:shakacode/react_on_rails.git", tag: "3.0.0-beta.1"
40+
gem "react_on_rails"
4141

4242
# See https://github.com/sstephenson/execjs#readme for more supported runtimes
4343
gem "therubyracer"

Gemfile.lock

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,3 @@
1-
GIT
2-
remote: [email protected]:shakacode/react_on_rails.git
3-
revision: 562c58f2b37e13cecc86fd4bd4e85edb10acd86d
4-
tag: 3.0.0-beta.1
5-
specs:
6-
react_on_rails (3.0.0.beta.1)
7-
connection_pool
8-
execjs (~> 2.5)
9-
foreman
10-
rails (>= 3.2)
11-
rainbow (~> 2.1)
12-
131
GEM
142
remote: https://rubygems.org/
153
specs:
@@ -213,6 +201,11 @@ GEM
213201
rake (10.5.0)
214202
rdoc (4.2.1)
215203
json (~> 1.4)
204+
react_on_rails (2.3.0)
205+
connection_pool
206+
execjs (~> 2.5)
207+
rails (>= 3.2)
208+
rainbow (~> 2.1)
216209
ref (2.0.0)
217210
rest-client (1.8.0)
218211
http-cookie (>= 1.0.2, < 2.0)
@@ -352,7 +345,7 @@ DEPENDENCIES
352345
rails-html-sanitizer
353346
rails_12factor
354347
rainbow
355-
react_on_rails!
348+
react_on_rails
356349
rspec-rails
357350
rspec-retry
358351
rubocop

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ See package.json and Gemfile for versions
6666
1. Be sure that you have Node installed! We suggest [nvm](https://github.com/creationix/nvm), with node version `v5.0` or above. See this article [Updating and using nvm](http://forum.shakacode.com/t/updating-and-using-nvm/293).
6767
1. `git clone [email protected]:shakacode/react-webpack-rails-tutorial.git`
6868
1. `cd react-webpack-rails-tutorial`
69-
1. Check that you have Ruby 2.2.4
69+
1. Check that you have Ruby 2.2.3
7070
1. Check that you're using the right version of node. Run `nvm list` to check.
7171
1. Check that you have Postgres installed. Run `which postgres` to check.
7272
1. `bundle install`

app/controllers/pages_controller.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ def index
66
# compared to he view. However, it's more convenient to use Jbuilder from the view. See
77
# app/views/pages/index.html.erb:20
88
#
9-
# <%= react_component('App', props: render(template: "/comments/index.json.jbuilder"),
9+
# <%= react_component('App', render(template: "/comments/index.json.jbuilder"),
1010
# prerender: true) %>
1111
#
1212
#

app/views/pages/index.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
<a href="https://github.com/shakacode/react_on_rails">react_on_rails gem</a>)</h2>
33
<%= render "header" %>
44

5-
<%= react_component('RouterApp', props: render(template: "/comments/index.json.jbuilder"),
5+
<%= react_component('RouterApp', render(template: "/comments/index.json.jbuilder"),
66
prerender: true, raise_on_prerender_error: true) %>

app/views/pages/no_router.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
<a href="https://github.com/shakacode/react_on_rails">react_on_rails gem</a>)</h2>
33
<%= render "header" %>
44

5-
<%= react_component('App', props: render(template: "/comments/index.json.jbuilder"),
5+
<%= react_component('App', render(template: "/comments/index.json.jbuilder"),
66
prerender: false) %>

app/views/pages/simple.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@
99
</ul>
1010
<hr/>
1111

12-
<%= react_component('SimpleCommentScreen', props: {}, prerender: false) %>
12+
<%= react_component('SimpleCommentScreen', {}, prerender: false) %>

0 commit comments

Comments
 (0)