Removed CommonSplitPlugin for SplitChunks

Author: pulkitkkr

client/package.json

@@ -41,12 +41,14 @@
     "lint": "eslint --ext .js,.jsx ."
   },
   "dependencies": {
+    "@babel/core": "^7.3.4",
+    "@babel/preset-env": "^7.3.4",
     "actioncable": "5.0.x",
     "autoprefixer": "^7.1.5",
     "axios": "^0.17.1",
     "babel-cli": "^6.26.0",
     "babel-core": "^6.26.0",
-    "babel-loader": "^7.1.2",
+    "babel-loader": "^7.1.5",
     "babel-plugin-transform-es2015-modules-amd": "^6.24.1",
     "babel-polyfill": "^6.26.0",
     "babel-preset-env": "^1.6.0",
@@ -56,13 +58,13 @@
     "bootstrap-loader": "^2.2.0",
     "bootstrap-sass": "^3.3.7",
     "classnames": "^2.2.5",
-    "compression-webpack-plugin": "^1.0.1",
+    "compression-webpack-plugin": "^2.0.0",
     "css-loader": "^0.28.7",
     "es5-shim": "^4.5.9",
     "estraverse": "^4.2.0",
-    "expose-loader": "^0.7.4",
+    "expose-loader": "^0.7.5",
     "extract-text-webpack-plugin": "^3.0.2",
-    "file-loader": "^1.1.5",
+    "file-loader": "^3.0.1",
     "glob": "^7.1.2",
     "immutable": "^3.8.2",
     "imports-loader": "^0.7.1",
@@ -72,8 +74,8 @@
     "js-yaml": "^3.10.0",
     "loader-utils": "^1.1.0",
     "lodash": "^4.17.4",
-    "marked": "^0.3.6",
-    "node-sass": "^4.7.2",
+    "marked": "^0.6.1",
+    "node-sass": "^4.11.0",
     "node-uuid": "^1.4.8",
     "postcss-loader": "^2.0.8",
     "prop-types": "^15.6.0",
@@ -91,12 +93,13 @@
     "redux-thunk": "^2.2.0",
     "resolve-url-loader": "^2.2.0",
     "sass-loader": "^6.0.6",
-    "sass-resources-loader": "^1.3.1",
+    "sass-resources-loader": "^1.3.3",
     "style-loader": "^0.19.0",
     "turbolinks": "^5.0.3",
     "url-loader": "^0.6.2",
-    "webpack": "^3.8.1",
-    "webpack-manifest-plugin": "^1.3.2",
+    "webpack": "^4.29.6",
+    "webpack-cli": "^3.3.0",
+    "webpack-manifest-plugin": "^2.0.4",
     "webpack-merge": "^4.1.1"
   },
   "devDependencies": {
@@ -114,11 +117,11 @@
     "express": "^4.16.2",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^23.5.0",
-    "pug": "^2.0.0-rc.4",
+    "pug": "^2.0.3",
     "react-transform-hmr": "^1.0.4",
     "regenerator-runtime": "^0.12.1",
     "sleep": "^5.1.1",
-    "webpack-dev-server": "^2.9.4"
+    "webpack-dev-server": "^3.2.1"
   },
   "jest": {
     "moduleNameMapper": {

client/webpack.client.base.config.js

@@ -16,6 +16,7 @@ module.exports = {
 
   // the project dir
   context: resolve(__dirname),
+  mode: process.env.NODE_ENV,
   entry: {
     // This will contain the app entry points defined by
     // webpack.client.rails.hot.config and webpack.client.rails.build.config
@@ -45,28 +46,25 @@ module.exports = {
       'client/node_modules',
     ],
   },
-
+  optimization: {
+    splitChunks: {
+      chunks: 'all',
+      cacheGroups: {
+        vendor: {
+          name: 'vendor',
+          test: /[\\/]node_modules[\\/]/,
+          priority: -10,
+        }
+      }
+    }
+  },
   plugins: [
     new webpack.EnvironmentPlugin({
       NODE_ENV: 'development', // use 'development' unless process.env.NODE_ENV is defined
       DEBUG: false,
       TRACE_TURBOLINKS: devBuild,
     }),
-
     // https://webpack.github.io/docs/list-of-plugins.html#2-explicit-vendor-chunk
-    new webpack.optimize.CommonsChunkPlugin({
-
-      // This name 'vendor-bundle' ties into the entry definition
-      name: 'vendor-bundle',
-
-      // We don't want the default vendor.js name
-      filename: 'vendor-bundle-[hash].js',
-
-      minChunks(module) {
-        // this assumes your vendor imports exist in the node_modules directory
-        return module.context && module.context.indexOf('node_modules') !== -1;
-      },
-    }),
     new ManifestPlugin({
       publicPath: output.publicPath,
       writeToFileEmit: true